Refactor SharedTokenCacheCredential exception handling #11962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangyan99
approved these changes
Jun 10, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jun 11, 2020
…into have_azure_key_credential_policy_take_kwargs * 'master' of https://github.com/Azure/azure-sdk-for-python: typing fix (Azure#11985) remove test code that works around service bug (fixed) (Azure#11961) Refactor SharedTokenCacheCredential exception handling (Azure#11962) add the previous versions of azure-servicebus to the regression exclusion list (Azure#11957) Increment package version after release of azure_ai_formrecognizer (Azure#11954) Remove redundant await_prepared_test (Azure#11930) update changelog date (Azure#11934) Sync eng/common directory with azure-sdk-tools repository (Azure#11925) [formrecognizer] update recordings, add delay, switch to westcentralus region (Azure#11916) Increment package version after release of azure_identity (Azure#11931) Resolve Breaking Aggregate Reports (Azure#11825) Increment package version after release of azure_ai_textanalytics (Azure#11928) update error msg if not supported (Azure#11915)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the way the credential handles exceptions from MSAL to make it possible for
get_tokento raiseValueErrorwhen called with no scopes. Closes #11553.