This repository has been archived by the owner on May 5, 2023. It is now read-only.
Run 'npm install' after generating and before publishing #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RikkiGibson
reviewed
Apr 4, 2018
| @@ -39,6 +39,10 @@ function getServiceNameFromOutputFolderValue(outputFolderValue) { | |||
| return outputFolderSegments[outputFolderSegments.length - 1]; | |||
| } | |||
|
|
|||
| function npmInstall(packageFolderPath) { | |||
| execSync(`npm install`, { cwd: packageFolderPath, stdio: ['ignore', 'ignore', 'pipe'] }); | |||
There was a problem hiding this comment.
does this make it so we only see errors from the child process?
RikkiGibson
approved these changes
Apr 4, 2018
daviddesberg
pushed a commit
to daviddesberg/azure-sdk-for-node
that referenced
this pull request
Apr 10, 2018
…ivate repo to preview (new pricing model api and migration apis) (Azure#2471) * Generated from 2685ce7f1e77eaab6332acccc8f1d7eba4b62aaf Revert "Fix AppInsights x-ms-parameter-location (Azure#2680)" This reverts commit 7c3b7239b11490d6badd532e742a6ae1d004a2b2. * Generated from c374857dcb08210e3104846f4b0a3706e17536ca change microsoft.insights to Microsoft.Insights
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.