Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Upgrade to 14.1.0 with latest swagger #8876

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Conversation

blueww
Copy link
Member

@blueww blueww commented Nov 22, 2019

Upgrade to latest swagger, and update version to 14.1.0

@blueww blueww requested a review from erich-wang as a code owner November 22, 2019 08:02
@isra-fel isra-fel self-assigned this Nov 25, 2019
@isra-fel isra-fel added needs-review Mgmt This issue is related to a management-plane library. labels Nov 25, 2019
@isra-fel isra-fel merged commit 0c095ad into Azure:master Nov 25, 2019
Copy link
Member

@gunjanj gunjanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be 102400, not 100,00 Check https://aka.ms/premiumfilesdocs.

Can we not hardcode and instead have a const define

@blueww
Copy link
Member Author

blueww commented Dec 4, 2019

@gunjanj
100,000 is from swagger. Azure/azure-rest-api-specs#7824
When swagger is fixed by Zhenfeng, I will fix SRP SDK and PSH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants