Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sdk due to billing plan swagger file change #8475

Merged
merged 6 commits into from
Nov 1, 2019

Conversation

Only2125
Copy link
Contributor

reservation has a swagger change for billing plan. need to update sdk.

@Only2125 Only2125 requested a review from erich-wang as a code owner October 28, 2019 04:39
@isra-fel isra-fel self-assigned this Oct 28, 2019
@isra-fel isra-fel added needs-review Mgmt This issue is related to a management-plane library. labels Oct 28, 2019
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Only2125 please put a link to your swagger spec review PR in the comments

@@ -0,0 +1,11 @@
2019-10-28 03:47:35 UTC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not exist

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I delete it manually? All it should never be generated?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was generated by generate.cmd right? That is discouraged and we recommend generate.ps1.
So please remove this file manually, and use generate.ps1 for all future code generation. Please remove generate.cmd as well. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address this issue as well, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted

@Only2125
Copy link
Contributor Author

Hey @Only2125 please put a link to your swagger spec review PR in the comments

Azure/azure-rest-api-specs#7541
Billing Plan swagger

@isra-fel isra-fel merged commit f922ba6 into Azure:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants