-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update sdk due to billing plan swagger file change #8475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Only2125 please put a link to your swagger spec review PR in the comments
...s/Microsoft.Azure.Management.Reservations/src/Microsoft.Azure.Management.Reservations.csproj
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,11 @@ | |||
2019-10-28 03:47:35 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should not exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I delete it manually? All it should never be generated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was generated by generate.cmd
right? That is discouraged and we recommend generate.ps1
.
So please remove this file manually, and use generate.ps1
for all future code generation. Please remove generate.cmd
as well. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address this issue as well, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted
Azure/azure-rest-api-specs#7541 |
reservation has a swagger change for billing plan. need to update sdk.