Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for SQL #7795

Merged
merged 3 commits into from
Oct 1, 2019
Merged

add support for SQL #7795

merged 3 commits into from
Oct 1, 2019

Conversation

gaurangisaxena
Copy link
Contributor

No description provided.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaurangisaxena Hi, there are two things need your attention:

  1. Please add a link to the swagger spec review PR in this PR's description
  2. The path of datashare_resource-manager.txt is wrong. It should be under eng\mgmt\mgmtmetadata

Thanks

@isra-fel isra-fel added needs-revision Mgmt This issue is related to a management-plane library. labels Sep 29, 2019
@dadihe
Copy link
Contributor

dadihe commented Sep 30, 2019

@gaurangisaxena Hi, there are two things need your attention:

  1. Please add a link to the swagger spec review PR in this PR's description
  2. The path of datashare_resource-manager.txt is wrong. It should be under eng\mgmt\mgmtmetadata

Thanks

@isra-fel

  1. here's the link to the swagger PR:
    https://github.com/Azure/azure-rest-api-specs-pr/pull/927
  2. I've move this file under eng\mgmt\mgmtmetadata folder.

please have a review if this looks good this time.

Thanks
Dadi

@markcowl markcowl dismissed isra-fel’s stale review October 1, 2019 13:25

All changes made

@markcowl markcowl merged commit beaf5aa into Azure:master Oct 1, 2019
@dadihe dadihe mentioned this pull request Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants