Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] Support Manage File Share #7550

Merged
merged 1 commit into from
Sep 11, 2019
Merged

[Storage] Support Manage File Share #7550

merged 1 commit into from
Sep 11, 2019

Conversation

blueww
Copy link
Member

@blueww blueww commented Sep 10, 2019 •
edited
Loading

Support Manage File Share and File Service Properties.

The SRP SDK code is generated from latest public swagger.

@blueww blueww requested a review from erich-wang as a code owner September 10, 2019 03:48
@blueww
Copy link
Member Author

blueww commented Sep 11, 2019

@erich-wang
Would you please help to look at the PR? We have a PSH feature which target code complete on 9/16 , depends on the PR merge to raise PSH PR.

There are 2 build failure, it seems not caused by my code, would you please help to look?
As I see, the error is:

D:\a\1\AzureSDKEngSystem\Net\SourceDirectory\eng\Directory.Build.Data.targets : error : Failed to resolve SDK 'Microsoft.Build.CentralPackageVersions/2.0.36'. Package restore was successful but a package with the ID of "Microsoft.Build.CentralPackageVersions" was not installed.

isra-fel
isra-fel approved these changes Sep 11, 2019
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit 3fd9df4 into Azure:master Sep 11, 2019
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-net Oct 21, 2019
Generated from e08f7a3ba78fe8ab91efcdacde25ab986c6eca0f
7ff20f7 
updating sdk tags for 2019-10-01 api version (#7550)

* updating sdk tags for 2019-10-01 api version

* fixing ci errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

@erich-wang erich-wang Awaiting requested review from erich-wang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blueww @isra-fel