Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move HTTP related types to http namespace, and policy types to Azure.Core.Pipeline #6939

Merged
merged 2 commits into from
Jul 16, 2019
Merged

Move HTTP related types to http namespace, and policy types to Azure.Core.Pipeline #6939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1aa17d
Move HTTP related types to http namespace
pakrym Jul 16, 2019
f73f8c6
Policy namespaces
pakrym Jul 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...configuration/Azure.ApplicationModel.Configuration/samples/Sample7_ConfiguringPipeline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
// license information.

using Azure.Core.Pipeline;
using Azure.Core.Pipeline.Policies;
using NUnit.Framework;
using System;
using System.Net.Http;
Expand Down
1 change: 0 additions & 1 deletion sdk/appconfiguration/Azure.ApplicationModel.Configuration/src/ConfigurationClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
using Azure.Core;
using Azure.Core.Http;
using Azure.Core.Pipeline;
using Azure.Core.Pipeline.Policies;

namespace Azure.ApplicationModel.Configuration
{
Expand Down
1 change: 1 addition & 0 deletions ...configuration/Azure.ApplicationModel.Configuration/src/ConfigurationClientModelFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Licensed under the MIT License.

using System;
using Azure.Core.Http;

namespace Azure.ApplicationModel.Configuration
{
Expand Down
1 change: 1 addition & 0 deletions sdk/appconfiguration/Azure.ApplicationModel.Configuration/src/ConfigurationClient_private.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
using System.Threading;
using System.Threading.Tasks;
using Azure.Core;
using Azure.Core.Http;
using Azure.Core.Pipeline;

namespace Azure.ApplicationModel.Configuration
Expand Down
1 change: 1 addition & 0 deletions sdk/appconfiguration/Azure.ApplicationModel.Configuration/src/ConfigurationSetting.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using System.Collections.Generic;
using System.ComponentModel;
using Azure.Core;
using Azure.Core.Http;

namespace Azure.ApplicationModel.Configuration
{
Expand Down
1 change: 1 addition & 0 deletions sdk/appconfiguration/Azure.ApplicationModel.Configuration/src/ConfigurationSettingParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
using System.Text.Json;
using System.Threading;
using System.Threading.Tasks;
using Azure.Core.Http;

namespace Azure.ApplicationModel.Configuration
{
Expand Down
1 change: 1 addition & 0 deletions sdk/appconfiguration/Azure.ApplicationModel.Configuration/tests/ConfigurationMockTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
using System.Text.Json;
using System.Threading;
using System.Threading.Tasks;
using Azure.Core.Http;
using NUnit.Framework;

namespace Azure.ApplicationModel.Configuration.Tests
Expand Down
1 change: 1 addition & 0 deletions sdk/appconfiguration/Azure.ApplicationModel.Configuration/tests/ConfigurationSettingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
using System;
using System.Collections.Generic;
using Azure.Core;
using Azure.Core.Http;

namespace Azure.ApplicationModel.Configuration.Tests
{
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/Azure.Core/src/ETag.cs → sdk/core/Azure.Core/src/Http/ETag.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

using System;

namespace Azure
namespace Azure.Core.Http
{
public readonly struct ETag : IEquatable<ETag>
{
Expand Down
0 ....Core/src/Pipeline/HttpClientTransport.cs → ...zure.Core/src/Http/HttpClientTransport.cs
View file
Open in desktop
File renamed without changes.
3 changes: 1 addition & 2 deletions sdk/core/Azure.Core/src/Http/HttpHeader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@
// Licensed under the MIT License.

using System;
using System.Runtime.InteropServices;

namespace Azure.Core.Pipeline
namespace Azure.Core.Http
{
public readonly struct HttpHeader : IEquatable<HttpHeader>
{
Expand Down
2 changes: 1 addition & 1 deletion .../Azure.Core/src/HttpPipelineUriBuilder.cs → ...e.Core/src/Http/HttpPipelineUriBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
using System;
using System.Text;

namespace Azure.Core
namespace Azure.Core.Http
{
public class RequestUriBuilder
{
Expand Down
1 change: 0 additions & 1 deletion sdk/core/Azure.Core/src/Http/HttpRange.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
using System;
using System.ComponentModel;
using System.Globalization;
using Azure.Core.Pipeline;

namespace Azure.Core.Http
{
Expand Down
1 change: 0 additions & 1 deletion sdk/core/Azure.Core/src/RequestHeaders.cs → ...ore/Azure.Core/src/Http/RequestHeaders.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

using System.Collections;
using System.Collections.Generic;
using Azure.Core.Pipeline;

namespace Azure.Core.Http
{
Expand Down
3 changes: 1 addition & 2 deletions sdk/core/Azure.Core/src/ResponseHeaders.cs → ...re/Azure.Core/src/Http/ResponseHeaders.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@
using System.Collections;
using System.Collections.Generic;
using System.Globalization;
using Azure.Core.Pipeline;

namespace Azure
namespace Azure.Core.Http
{
public readonly struct ResponseHeaders: IEnumerable<HttpHeader>
{
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/Azure.Core/src/OperationOfT.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ protected set
public abstract bool HasValue { get; }

/// <summary>
/// Polling interval used by WaitCompletionAsync method.
/// Polling interval used by WaitCompletionAsync method.
/// </summary>
/// <remarks>
/// The interval can change based on information returned from the server.
Expand Down
5 changes: 3 additions & 2 deletions ...licies/BearerTokenAuthenticationPolicy.cs → ...peline/BearerTokenAuthenticationPolicy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,16 @@
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using Azure.Core.Http;

namespace Azure.Core.Pipeline.Policies
namespace Azure.Core.Pipeline
{
public class BearerTokenAuthenticationPolicy: HttpPipelinePolicy
{
private readonly TokenCredential _credential;

private readonly string[] _scopes;

private string _headerValue;

private DateTimeOffset _refreshOn;
Expand Down
2 changes: 1 addition & 1 deletion ...Pipeline/Policies/BufferResponsePolicy.cs → ...Core/src/Pipeline/BufferResponsePolicy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
using System.IO;
using System.Threading.Tasks;

namespace Azure.Core.Pipeline.Policies
namespace Azure.Core.Pipeline
{
internal class BufferResponsePolicy: HttpPipelinePolicy
{
Expand Down
2 changes: 1 addition & 1 deletion ...ipeline/Policies/ClientRequestIdPolicy.cs → ...ore/src/Pipeline/ClientRequestIdPolicy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

namespace Azure.Core.Pipeline.Policies
namespace Azure.Core.Pipeline
{
internal class ClientRequestIdPolicy : SynchronousHttpPipelinePolicy
{
Expand Down
1 change: 0 additions & 1 deletion sdk/core/Azure.Core/src/Pipeline/HttpPipelineBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
using System;
using System.Collections.Generic;
using System.Reflection;
using Azure.Core.Pipeline.Policies;

namespace Azure.Core.Pipeline
{
Expand Down
3 changes: 2 additions & 1 deletion ...re/src/Pipeline/Policies/LoggingPolicy.cs → .../Azure.Core/src/Pipeline/LoggingPolicy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@
using System.Threading;
using System.Threading.Tasks;
using Azure.Core.Diagnostics;
using Azure.Core.Http;

namespace Azure.Core.Pipeline.Policies
namespace Azure.Core.Pipeline
{
internal class LoggingPolicy : HttpPipelinePolicy
{
Expand Down
3 changes: 1 addition & 2 deletions sdk/core/Azure.Core/src/RetriableStream.cs → ...zure.Core/src/Pipeline/RetriableStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,8 @@
using System.Threading;
using System.Threading.Tasks;
using Azure.Core.Pipeline;
using Azure.Core.Pipeline.Policies;

namespace Azure.Core
namespace Azure.Core.Pipeline
{
public static class RetriableStream
{
Expand Down
1 change: 0 additions & 1 deletion sdk/core/Azure.Core/src/Pipeline/RetryOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// Licensed under the MIT License.

using System;
using Azure.Core.Pipeline.Policies;

namespace Azure.Core.Pipeline
{
Expand Down
2 changes: 1 addition & 1 deletion ...Core/src/Pipeline/Policies/RetryPolicy.cs → ...re/Azure.Core/src/Pipeline/RetryPolicy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
using System.Threading.Tasks;
using Azure.Core.Diagnostics;

namespace Azure.Core.Pipeline.Policies
namespace Azure.Core.Pipeline
{
internal class RetryPolicy : HttpPipelinePolicy
{
Expand Down
2 changes: 1 addition & 1 deletion ...e/src/Pipeline/Policies/TaskExtensions.cs → ...Azure.Core/src/Pipeline/TaskExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
using System.Diagnostics;
using System.Threading.Tasks;

namespace Azure.Core.Pipeline.Policies
namespace Azure.Core.Pipeline
{
internal static class TaskExtensions
{
Expand Down
5 changes: 3 additions & 2 deletions .../src/Pipeline/Policies/TelemetryPolicy.cs → ...zure.Core/src/Pipeline/TelemetryPolicy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@
// Licensed under the MIT License.

using System.Runtime.InteropServices;
using Azure.Core.Http;

namespace Azure.Core.Pipeline.Policies
namespace Azure.Core.Pipeline
{
public class TelemetryPolicy : SynchronousHttpPipelinePolicy
internal class TelemetryPolicy : SynchronousHttpPipelinePolicy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentional? It's the only non-namespace change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I noticed that I forgot TelemetryPolicy when making build-in policies internal.

{
private readonly string _header;

Expand Down
1 change: 1 addition & 0 deletions sdk/core/Azure.Core/src/Response.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Collections.Generic;
using System.IO;
using Azure.Core.Http;
using Azure.Core.Pipeline;

namespace Azure
Expand Down
2 changes: 0 additions & 2 deletions sdk/core/Azure.Core/src/ResponseExceptionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

using System;
using System.Globalization;
using System.IO;
using System.Text;
using System.Threading.Tasks;
using Azure.Core.Pipeline;
using Azure.Core.Pipeline.Policies;

namespace Azure.Core
{
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/Azure.Core/tests/BearerTokenAuthenticationPolicyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using Azure.Core.Pipeline.Policies;
using Azure.Core.Pipeline;
using Azure.Core.Testing;
using Moq;
using NUnit.Framework;
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/Azure.Core/tests/BufferResponsePolicyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
using System;
using System.IO;
using System.Threading.Tasks;
using Azure.Core.Pipeline.Policies;
using Azure.Core.Pipeline;
using Azure.Core.Testing;
using NUnit.Framework;

Expand Down
2 changes: 1 addition & 1 deletion sdk/core/Azure.Core/tests/ClientRequestIdPolicyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Licensed under the MIT License.

using System.Threading.Tasks;
using Azure.Core.Pipeline.Policies;
using Azure.Core.Pipeline;
using Azure.Core.Testing;
using NUnit.Framework;

Expand Down
5 changes: 1 addition & 4 deletions sdk/core/Azure.Core/tests/ETagTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

using System;
using System.Collections.Generic;
using System.Text;
using NUnit;
using Azure.Core.Http;
using NUnit.Framework;

namespace Azure.Core.Tests
Expand Down
1 change: 0 additions & 1 deletion sdk/core/Azure.Core/tests/EventSourceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
using Azure.Core.Diagnostics;
using Azure.Core.Http;
using Azure.Core.Pipeline;
using Azure.Core.Pipeline.Policies;
using Azure.Core.Testing;
using NUnit.Framework;

Expand Down
3 changes: 1 addition & 2 deletions sdk/core/Azure.Core/tests/ExponentialPolicyTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
// Licensed under the MIT License.

using System;
using System.Threading;
using System.Threading.Tasks;
using Azure.Core.Http;
using Azure.Core.Pipeline;
using Azure.Core.Pipeline.Policies;
using Azure.Core.Testing;
using NUnit.Framework;

Expand Down
1 change: 1 addition & 0 deletions sdk/core/Azure.Core/tests/FailedResponseExceptionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

using System;
using System.Threading.Tasks;
using Azure.Core.Http;
using Azure.Core.Pipeline;
using Azure.Core.Testing;
using NUnit.Framework;
Expand Down
3 changes: 1 addition & 2 deletions sdk/core/Azure.Core/tests/FixedRetryPolicyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
// Licensed under the MIT License.

using System;
using System.Threading;
using System.Threading.Tasks;
using Azure.Core.Http;
using Azure.Core.Pipeline;
using Azure.Core.Pipeline.Policies;
using Azure.Core.Testing;
using NUnit.Framework;

Expand Down
1 change: 1 addition & 0 deletions sdk/core/Azure.Core/tests/HeadersTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using System;
using System.Text;
using System.Text.RegularExpressions;
using Azure.Core.Http;
using Azure.Core.Pipeline;
using Azure.Core.Testing;
using NUnit.Framework;
Expand Down
2 changes: 0 additions & 2 deletions sdk/core/Azure.Core/tests/PipelineTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,9 @@
// Licensed under the MIT License.

using Azure.Core.Pipeline;
using Azure.Core.Pipeline.Policies;
using Azure.Core.Testing;
using NUnit.Framework;
using System;
using System.Collections.Generic;
using System.Threading;
using System.Threading.Tasks;

Expand Down
1 change: 1 addition & 0 deletions sdk/core/Azure.Core/tests/RequestUriBuilderTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Licensed under the MIT License.

using System;
using Azure.Core.Http;
using NUnit.Framework;

namespace Azure.Core.Tests
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/Azure.Core/tests/RetryPolicyTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
using System.Threading;
using System.Threading.Tasks;
using Azure.Core.Diagnostics;
using Azure.Core.Http;
using Azure.Core.Pipeline;
using Azure.Core.Pipeline.Policies;
using Azure.Core.Testing;
using NUnit.Framework;

Expand Down
2 changes: 0 additions & 2 deletions sdk/core/Azure.Core/tests/TelemetryPolicyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,9 @@
// Licensed under the MIT License.

using System;
using System.Reflection;
using System.Runtime.InteropServices;
using System.Threading.Tasks;
using Azure.Core.Pipeline;
using Azure.Core.Pipeline.Policies;
using Azure.Core.Testing;
using NUnit.Framework;

Expand Down
1 change: 1 addition & 0 deletions sdk/core/Azure.Core/tests/TestFramework/MockResponse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using System.IO;
using System.Linq;
using System.Text;
using Azure.Core.Http;
using Azure.Core.Pipeline;

namespace Azure.Core.Testing
Expand Down
Loading