Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keys Sync implementation #6490

Merged
merged 3 commits into from
Jun 7, 2019
Merged

Keys Sync implementation #6490

merged 3 commits into from
Jun 7, 2019

Conversation

maririos
Copy link
Member

@maririos maririos commented Jun 5, 2019

It depends on PR #6479 so while that one gets merged, marking this one as draft.

Actual changes for this PR are in commit 5850d36


Update: PR has been updated to include latest changes in the Keys API.
It is ready to review

@maririos maririos added Client This issue points to a problem in the data-plane of the library. KeyVault labels Jun 5, 2019
@maririos maririos self-assigned this Jun 5, 2019
@maririos maririos requested review from schaabs and AlexGhiondea June 5, 2019 18:27
@maririos maririos marked this pull request as ready for review June 7, 2019 22:28
@maririos maririos requested review from pakrym and jsquire June 7, 2019 22:29
Copy link
Member

@schaabs schaabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@maririos maririos merged commit 6d3cabc into Azure:master Jun 7, 2019
@maririos maririos deleted the sync branch July 11, 2019 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants