Initial MSI credential implementation #6464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym
reviewed
Jun 3, 2019
|
As I understand live tests are hard to write for MSI, can we add mocking tests for this implementation? |
AlexGhiondea
approved these changes
Jun 3, 2019
jsquire
approved these changes
Jun 3, 2019
| @@ -20,6 +20,8 @@ internal class IdentityClient | |||
| { | |||
| private readonly IdentityClientOptions _options; | |||
| private readonly HttpPipeline _pipeline; | |||
| private readonly Uri ImdsEndptoint = new Uri("http://169.254.169.254/metadata/identity/oauth2/token"); | |||
There was a problem hiding this comment.
Should we consider allowing this to be overridden by environment or options?
pakrym
reviewed
Jun 5, 2019
|
|
||
| namespace Azure.Identity.Tests.Mock | ||
| { | ||
| class MockToken |
pakrym
reviewed
Jun 5, 2019
| Assert.AreEqual("tokenA", await provider.GetTokenAsync(new string[] { "scopeA" })); | ||
| Assert.AreEqual("tokenB", await provider.GetTokenAsync(new string[] { "scopeB" })); | ||
| Assert.AreEqual("tokenC", await provider.GetTokenAsync(new string[] { "scopeC" })); | ||
| // await Assert.ThrowsAsync<InvalidOperationException>(async () => await provider.GetTokenAsync(new string[] { "scopeD" })); |
There was a problem hiding this comment.
Is this commented out by accident?
…nto identity-msi
|
@schaabs can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.