Enable recording in Secrets test #6463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto keyvault-tests
…nto keyvault-tests
AlexGhiondea
reviewed
Jun 3, 2019
| { | ||
| string modeString = Environment.GetEnvironmentVariable(ModeEnvironmentVariableName); | ||
| mode = (RecordedTestMode)Enum.Parse(typeof(RecordedTestMode), modeString, true); |
There was a problem hiding this comment.
This will fail if the value is misspelled. Should we use Enum.TryPare instead and throw a better error message in that case?
There was a problem hiding this comment.
The exception that is being thrown is not that bad I think it would be pretty obvious where the problem is.
AlexGhiondea
approved these changes
Jun 3, 2019
AlexGhiondea
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.