Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common properties file to test framework #6452

Merged

Conversation

pakrym
Copy link
Contributor

@pakrym pakrym commented May 31, 2019

Improving 2 things:

  1. Groups shared files into a directory:

Before:
image

After:
image

  1. Avoiding everyone having to add None Update="SessionRecords\**\*.json" into every test project.

Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be very nice to break the shared areas for the framework into a project that could be referenced but not included in the solution for a client library in the same manner as Core.

That would avoid the appearance that the client library owns the files and the expectation that changes are scoped to only that library and, therefore, safe.

@pakrym
Copy link
Contributor Author

pakrym commented May 31, 2019

I would be happy to extract the test framework into a project/package but there are some related infrastructure challenges we don't want to address right now.

@pakrym pakrym merged commit cacb0de into Azure:master May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants