Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keys API changes after the API Review #6425

Merged
merged 6 commits into from
May 30, 2019
Merged

Keys API changes after the API Review #6425

merged 6 commits into from
May 30, 2019

Conversation

maririos
Copy link
Member

Changes applied:

  • Update methods should take IEnumerable instead of IList
  • Remove CreateKey method that only takes KeyCreateOptions
  • Change DateTime references to DateTimeOffset
  • Change KeyOps variable name for KeyOperations
  • All list operations should be GetKeys - ish (not contain All)
  • GetKeys should return KeyBase, not Key (async and sync)
  • GetKeysVersions should return KeyBase, not Key (async and sync)
  • Remove JsonWeb from types like JsonWebKeyType, JsonWebKeyOperations, and JsonWebKeyCurveName,
  • Convert to enum the JsonWeb types

It also:

  • Renames the folder of the project form Keyvault to KeyVault
  • Add copyright info in each file

@maririos maririos added Client This issue points to a problem in the data-plane of the library. KeyVault labels May 28, 2019
@maririos maririos self-assigned this May 28, 2019
@maririos
Copy link
Member Author

Testing @Azure/adp-keyvault

@maririos
Copy link
Member Author

Could someone please review this PR?

@maririos maririos requested a review from KrzysztofCwalina May 30, 2019 15:57
@maririos
Copy link
Member Author

@KrzysztofCwalina could you please take a look?

@maririos maririos merged commit 99d3013 into Azure:master May 30, 2019
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@maririos @mentat9
Keys API changes after the API Review (Azure#6425)
23481d3 
* renaming directory

* add copyright to Keys

* API review changes

* DateTime to DateTimeOffset

* DateTimeOffset attributes

* remove extra spaces
@maririos maririos deleted the keysAPIReview branch July 11, 2019 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexGhiondea AlexGhiondea AlexGhiondea approved these changes

@g2vinay g2vinay Awaiting requested review from g2vinay

@schaabs schaabs Awaiting requested review from schaabs

@samvaity samvaity Awaiting requested review from samvaity

@chlowell chlowell Awaiting requested review from chlowell

@sadasant sadasant Awaiting requested review from sadasant

@sophiajt sophiajt Awaiting requested review from sophiajt

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina

Assignees

@maririos maririos

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maririos @AlexGhiondea