Update services.proj #6415
Merged
Update services.proj #6415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add default value of "*" for ServiceDirectory
- Add validation to ensure we have at least one project
- Add extension so services can add or remove default projects
For example if a service wants to exclude all projects under a tools folder
they would create a file like sdk\service\service.projects with:
<Project>
<ItemGroup>
<ProjectReference Remove="$(MSBuildThisFileDirectory)**\tools\**\*.csproj" />
</ItemGroup>
</Project>
mitchdenny
reviewed
May 24, 2019
No it only mutates what was selected. If you see my example in the description it just removes items from the project reference set. |
chidozieononiwu
approved these changes
May 24, 2019
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example if a service wants to exclude all projects under a tools folder
they would create a file like sdk\service\service.projects with:
PTAL @mitchdenny @chidozieononiwu
cc @azure/azure-sdk-eng