Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup HttpPipelineMessage and HttpClientOptions #6413

Merged
merged 4 commits into from
May 24, 2019

Conversation

pakrym
Copy link
Contributor

@pakrym pakrym commented May 24, 2019

  1. Remove IServiceProvider from client options and transport as we don't use it
  2. Remove HttpMessageOptions as they are not used
  3. Rename HttpPipelineMessage.Cancellation to CancellationToken for consistency

Breaking change

Before:

    class Policy : HttpPipelinePolicy
    {
        private async Task ProcessAsync(HttpPipelineMessage message, ReadOnlyMemory<HttpPipelinePolicy> pipeline)
        {
            await DoSomething(message.Cancellation);
        }
    }

After:

    class Policy : HttpPipelinePolicy
    {
        private async Task ProcessAsync(HttpPipelineMessage message, ReadOnlyMemory<HttpPipelinePolicy> pipeline)
        {
            await DoSomething(message.CancellationToken);
        }
    }

Copy link
Member

@tg-msft tg-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of questions, but I think the cleaning looks good.

@pakrym pakrym merged commit 9a7eb2d into Azure:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants