Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Raw to GetRawResponse #6412

Merged
merged 2 commits into from
May 24, 2019
Merged

Conversation

pakrym
Copy link
Contributor

@pakrym pakrym commented May 24, 2019

As discussed in the email thread renaming Response<T>.Raw to Response<T>.GetRawResponse() to make it easy for customers to discover the Value property.

Breaking change

Before:

Response<Model> response = ...;
Response raw = response.Raw;

After:

Response<Model> response = ...;
Response raw = response.GetRawResponse();

Copy link
Member

@tg-msft tg-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missing a few other test projects per the CI, but the change to Azure.Core looks good.

Can you also add the breaking change label and include before/after code samples?

@pakrym
Copy link
Contributor Author

pakrym commented May 24, 2019

Hm, I thought I have a solution with all of them, will fix.

@tg-msft
Copy link
Member

tg-msft commented May 24, 2019

Looks good

Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pakrym pakrym merged commit f7a0337 into Azure:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants