Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables mgmt build on sdk/ folder and disables old azure-sdk-for-net… #6392

Conversation

mitchdenny
Copy link
Contributor

This PR finalizes the transition to the shorter running PR validation pipelines that have been setup. Basically once this merges people who are working exclusively in the sdk/ folder won't need to worry about waiting for the azure-sdk-for-net - mgmt or azure-sdk-for-net - client pipelines to run.

@mitchdenny mitchdenny requested a review from weshaggard May 22, 2019 21:20
@mitchdenny mitchdenny self-assigned this May 22, 2019
@mitchdenny mitchdenny requested a review from dsgouda May 22, 2019 21:40
@mitchdenny mitchdenny force-pushed the users/mitchdenny/disable-management-builds-on-sdk branch from 00a97f1 to 164ae8a Compare May 23, 2019 03:53
@mitchdenny
Copy link
Contributor Author

I've disabled the CI and PR triggers in the defintiion in Azure DevOps so it won't fire anymore and I've removed the client.ymll file in this PR. Once its merged I'll hold off deleting the old pipeline definition for a while since once we delete it all the history is gone. But we can clean it up in a week or so (unless you don't think that there is any value in keeping it around for a bit longer).

@weshaggard
Copy link
Member

But we can clean it up in a week or so (unless you don't think that there is any value in keeping it around for a bit longer).

For the one in the public team there isn't any real value in keeping it around. We still have the equivalent "net - client" in internal.

@mitchdenny mitchdenny merged commit d615178 into Azure:master May 23, 2019
@mitchdenny mitchdenny deleted the users/mitchdenny/disable-management-builds-on-sdk branch May 23, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants