Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventGrid: 2019-06-01 .NET SDK generation #6382

Merged
merged 4 commits into from
May 22, 2019
Merged

Conversation

ahamad-MS
Copy link
Contributor

@ahamad-MS ahamad-MS commented May 22, 2019

Add the generated .NET SDK for 2019-06-01 API Version.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please generate the code using generate.ps1 script and commit changes to the .txt log file too.

@ahamad-MS ahamad-MS changed the title 2019-02-01 .NET SDK generation EventGrid: 2019-02-01 .NET SDK generation May 22, 2019
@ahamad-MS
Copy link
Contributor Author

Thanks @dsgouda .. I added the ../../AzSdk.RP.props file.

@dsgouda
Copy link
Contributor

dsgouda commented May 22, 2019

@ahamad-MS I was referring to the .txt file that should have some changes when you generate the code using generate.ps1 script

@ahamad-MS
Copy link
Contributor Author

@dsgouda I added the src\sdks_metadata\eventgrid_resource-manager.txt file.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the version to 4.1.0-preview in csproj/assemblyinfo.cs files and update the PackageReleaseNotes

@ahamad-MS ahamad-MS changed the title EventGrid: 2019-02-01 .NET SDK generation EventGrid: 2019-06-01 .NET SDK generation May 22, 2019
@ahamad-MS
Copy link
Contributor Author

@dsgouda Updated the release notes and assembly info with version 5.0.0 as this is GA version for us.

@@ -6,10 +6,10 @@
<PropertyGroup>
<PackageId>Microsoft.Azure.Management.EventGrid</PackageId>
<Description>Provides developers with a library to create and manage all Azure EventGrid resources. </Description>
<Version>4.0.1-preview</Version>
<Version>5.0.0</Version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you wish to publish a stable version right away, generally we recommend publishing a few preview versions before going stable, that way you have some leeway to implement fixes and such which wouldn't be a breaking change to customers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These features had been in preview for quite sometime. We had some of them introduced in 2018-09-15-preview and in 2019-02-01-preview. We are GA'ing them here in 2019-06-01. So, we are good to go.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit ea55a34 into Azure:master May 22, 2019
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
* 2019-02-01 .NET SDK generation

* Add missing file

* Add missing _metadata/eventgrid_resource-manager.txt file

* Update Release notes and assemblyinfo
@ahamad-MS ahamad-MS deleted the master branch November 4, 2019 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants