-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EventGrid: 2019-06-01 .NET SDK generation #6382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please generate the code using generate.ps1 script and commit changes to the .txt log file too.
Thanks @dsgouda .. I added the ../../AzSdk.RP.props file. |
@ahamad-MS I was referring to the .txt file that should have some changes when you generate the code using generate.ps1 script |
@dsgouda I added the src\sdks_metadata\eventgrid_resource-manager.txt file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bump the version to 4.1.0-preview
in csproj/assemblyinfo.cs files and update the PackageReleaseNotes
@dsgouda Updated the release notes and assembly info with version 5.0.0 as this is GA version for us. |
@@ -6,10 +6,10 @@ | |||
<PropertyGroup> | |||
<PackageId>Microsoft.Azure.Management.EventGrid</PackageId> | |||
<Description>Provides developers with a library to create and manage all Azure EventGrid resources. </Description> | |||
<Version>4.0.1-preview</Version> | |||
<Version>5.0.0</Version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you wish to publish a stable version right away, generally we recommend publishing a few preview versions before going stable, that way you have some leeway to implement fixes and such which wouldn't be a breaking change to customers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These features had been in preview for quite sometime. We had some of them introduced in 2018-09-15-preview and in 2019-02-01-preview. We are GA'ing them here in 2019-06-01. So, we are good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* 2019-02-01 .NET SDK generation * Add missing file * Add missing _metadata/eventgrid_resource-manager.txt file * Update Release notes and assemblyinfo
Add the generated .NET SDK for 2019-06-01 API Version.