Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce re-recording diff #6361

Merged
merged 5 commits into from
May 21, 2019
Merged

Reduce re-recording diff #6361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dd9c05e
Reduce re-recording diff
pakrym May 21, 2019
fdb86e8
Nice diff
pakrym May 21, 2019
3ad736c
Done
pakrym May 21, 2019
63439d5
Do it other way
pakrym May 21, 2019
d7506ee
Merge remote-tracking branch 'azure/master' into pakrym/reduce-diff
pakrym May 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sdk/appconfiguration/Azure.ApplicationModel.Configuration/tests/ConfigurationLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,11 +501,16 @@ public async Task UpdateSettingTags()
[Test]
public async Task GetRevisions()
{
// The service keeps revision history even after the key was removed
// Avoid reusing ids
Recording.DisableIdReuse();

ConfigurationClient service = GetClient();
ConfigurationSetting testSetting = CreateSetting();

//Prepare environment
ConfigurationSetting setting = testSetting;

setting.Key = GenerateKeyId("key-");
var testSettingUpdate = setting.Clone();
testSettingUpdate.Label = "test_label_update";
Expand Down
68 changes: 34 additions & 34 deletions ...onModel.Configuration/tests/SessionRecords/ConfigurationLiveTests/AddExistingSetting.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
{
"Entries": [
{
"RequestUri": "https://pakrym-azconfig-ui.azconfig.io/kv/key-895302012?label=test_label",
"RequestUri": "https://pakrym-azconfig-ui.azconfig.io/kv/key-1068237825?label=test_label",
"RequestMethod": "PUT",
"RequestHeaders": {
"Accept": "application/vnd.microsoft.appconfig.kv\u002bjson",
"Authorization": "Sanitized",
"Content-Type": "application/json",
"Date": "Mon, 20 May 2019 18:32:32 GMT",
"Date": "Tue, 21 May 2019 17:38:26 GMT",
"If-None-Match": "*",
"User-Agent": [
"azsdk-net-config/1.0.0.0",
"(.NET Core 4.6.27617.04; Microsoft Windows 10.0.16299 )"
],
"x-ms-client-request-id": "9aab963b-fb17-433d-8acf-0d630314c5c0",
"x-ms-client-request-id": "f16de15eb1f2478408b6dfa0275c981b",
"x-ms-content-sha256": "b11OQu6GthUatwGXUIKHHSRVyik0TdrUk5kZm3yZd2A=",
"x-ms-return-client-request-id": "true"
},
Expand All @@ -29,20 +29,20 @@
"ResponseHeaders": {
"Connection": "keep-alive",
"Content-Type": "application/vnd.microsoft.appconfig.kv\u002bjson; charset=utf-8",
"Date": "Mon, 20 May 2019 18:32:33 GMT",
"ETag": "\u0022aBGO4uP5Md7x4YR7BFaTlfJNCVM\u0022",
"Last-Modified": "Mon, 20 May 2019 18:32:33 GMT",
"Date": "Tue, 21 May 2019 17:38:26 GMT",
"ETag": "\u0022qXkQof2lljee0ASWkUl6vN9xJkK\u0022",
"Last-Modified": "Tue, 21 May 2019 17:38:26 GMT",
"Server": "nginx/1.13.9",
"Strict-Transport-Security": "max-age=15724800; includeSubDomains;",
"Sync-Token": "zAJw6V16=NDotMSMxOTU5NjU=;sn=195965",
"Sync-Token": "zAJw6V16=NDotMSMxOTc4NDg=;sn=197848",
"Transfer-Encoding": "chunked",
"x-ms-client-request-id": "9aab963b-fb17-433d-8acf-0d630314c5c0",
"x-ms-correlation-request-id": "060e83c1-0592-4659-afba-82c94f924a6c",
"x-ms-request-id": "060e83c1-0592-4659-afba-82c94f924a6c"
"x-ms-client-request-id": "f16de15eb1f2478408b6dfa0275c981b",
"x-ms-correlation-request-id": "1b2ad0c4-3e38-4e27-a1a7-74957f6edd32",
"x-ms-request-id": "1b2ad0c4-3e38-4e27-a1a7-74957f6edd32"
},
"ResponseBody": {
"etag": "aBGO4uP5Md7x4YR7BFaTlfJNCVM",
"key": "key-895302012",
"etag": "qXkQof2lljee0ASWkUl6vN9xJkK",
"key": "key-1068237825",
"label": "test_label",
"content_type": "test_content_type",
"value": "test_value",
Expand All @@ -51,23 +51,23 @@
"tag2": "value2"
},
"locked": false,
"last_modified": "2019-05-20T18:32:33\u002b00:00"
"last_modified": "2019-05-21T17:38:26\u002b00:00"
}
},
{
"RequestUri": "https://pakrym-azconfig-ui.azconfig.io/kv/key-895302012?label=test_label",
"RequestUri": "https://pakrym-azconfig-ui.azconfig.io/kv/key-1068237825?label=test_label",
"RequestMethod": "PUT",
"RequestHeaders": {
"Accept": "application/vnd.microsoft.appconfig.kv\u002bjson",
"Authorization": "Sanitized",
"Content-Type": "application/json",
"Date": "Mon, 20 May 2019 18:32:33 GMT",
"Date": "Tue, 21 May 2019 17:38:26 GMT",
"If-None-Match": "*",
"User-Agent": [
"azsdk-net-config/1.0.0.0",
"(.NET Core 4.6.27617.04; Microsoft Windows 10.0.16299 )"
],
"x-ms-client-request-id": "41102d79-eb9e-46dd-9350-6bf4d82a08c4",
"x-ms-client-request-id": "7da3e323d12a50be5444c374ca23148f",
"x-ms-content-sha256": "b11OQu6GthUatwGXUIKHHSRVyik0TdrUk5kZm3yZd2A=",
"x-ms-return-client-request-id": "true"
},
Expand All @@ -83,26 +83,26 @@
"ResponseHeaders": {
"Connection": "keep-alive",
"Content-Length": "0",
"Date": "Mon, 20 May 2019 18:32:33 GMT",
"Date": "Tue, 21 May 2019 17:38:26 GMT",
"Server": "nginx/1.13.9",
"Strict-Transport-Security": "max-age=15724800; includeSubDomains;",
"x-ms-client-request-id": "41102d79-eb9e-46dd-9350-6bf4d82a08c4",
"x-ms-correlation-request-id": "c2df672a-2d1a-4211-9907-8232233796af",
"x-ms-request-id": "c2df672a-2d1a-4211-9907-8232233796af"
"x-ms-client-request-id": "7da3e323d12a50be5444c374ca23148f",
"x-ms-correlation-request-id": "6d9b35b7-9df6-4de5-9543-c9f46ccfebd3",
"x-ms-request-id": "6d9b35b7-9df6-4de5-9543-c9f46ccfebd3"
},
"ResponseBody": null
},
{
"RequestUri": "https://pakrym-azconfig-ui.azconfig.io/kv/key-895302012?label=test_label",
"RequestUri": "https://pakrym-azconfig-ui.azconfig.io/kv/key-1068237825?label=test_label",
"RequestMethod": "DELETE",
"RequestHeaders": {
"Authorization": "Sanitized",
"Date": "Mon, 20 May 2019 18:32:33 GMT",
"Date": "Tue, 21 May 2019 17:38:26 GMT",
"User-Agent": [
"azsdk-net-config/1.0.0.0",
"(.NET Core 4.6.27617.04; Microsoft Windows 10.0.16299 )"
],
"x-ms-client-request-id": "86b79f0c-07e3-480d-b63a-abc44853f111",
"x-ms-client-request-id": "fb6890a452738443ea8b3be2df6efe18",
"x-ms-content-sha256": "47DEQpj8HBSa\u002b/TImW\u002b5JCeuQeRkm5NMpJWZG3hSuFU=",
"x-ms-return-client-request-id": "true"
},
Expand All @@ -111,20 +111,20 @@
"ResponseHeaders": {
"Connection": "keep-alive",
"Content-Type": "application/vnd.microsoft.appconfig.kv\u002bjson; charset=utf-8",
"Date": "Mon, 20 May 2019 18:32:33 GMT",
"ETag": "\u0022aBGO4uP5Md7x4YR7BFaTlfJNCVM\u0022",
"Last-Modified": "Mon, 20 May 2019 18:32:33 GMT",
"Date": "Tue, 21 May 2019 17:38:26 GMT",
"ETag": "\u0022qXkQof2lljee0ASWkUl6vN9xJkK\u0022",
"Last-Modified": "Tue, 21 May 2019 17:38:26 GMT",
"Server": "nginx/1.13.9",
"Strict-Transport-Security": "max-age=15724800; includeSubDomains;",
"Sync-Token": "zAJw6V16=NDotMSMxOTU5NjY=;sn=195966",
"Sync-Token": "zAJw6V16=NDotMSMxOTc4NDk=;sn=197849",
"Transfer-Encoding": "chunked",
"x-ms-client-request-id": "86b79f0c-07e3-480d-b63a-abc44853f111",
"x-ms-correlation-request-id": "6494fc19-1f2c-432c-a200-7113f6868efa",
"x-ms-request-id": "6494fc19-1f2c-432c-a200-7113f6868efa"
"x-ms-client-request-id": "fb6890a452738443ea8b3be2df6efe18",
"x-ms-correlation-request-id": "ea7df94f-c427-48ed-b84c-b1155654e0b9",
"x-ms-request-id": "ea7df94f-c427-48ed-b84c-b1155654e0b9"
},
"ResponseBody": {
"etag": "aBGO4uP5Md7x4YR7BFaTlfJNCVM",
"key": "key-895302012",
"etag": "qXkQof2lljee0ASWkUl6vN9xJkK",
"key": "key-1068237825",
"label": "test_label",
"content_type": "test_content_type",
"value": "test_value",
Expand All @@ -133,12 +133,12 @@
"tag2": "value2"
},
"locked": false,
"last_modified": "2019-05-20T18:32:33\u002b00:00"
"last_modified": "2019-05-21T17:38:26\u002b00:00"
}
}
],
"Variables": {
"APP_CONFIG_CONNECTION": "Endpoint=https://pakrym-azconfig-ui.azconfig.io;Id=0-l1-s0:h5pHKElA5IjSL3z\u002bFOYz;Secret=;",
"RandomSeed": "266346065"
"RandomSeed": "82284255"
}
}
68 changes: 34 additions & 34 deletions ...el.Configuration/tests/SessionRecords/ConfigurationLiveTests/AddExistingSettingAsync.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
{
"Entries": [
{
"RequestUri": "https://pakrym-azconfig-ui.azconfig.io/kv/key-1269329324?label=test_label",
"RequestUri": "https://pakrym-azconfig-ui.azconfig.io/kv/key-314090486?label=test_label",
"RequestMethod": "PUT",
"RequestHeaders": {
"Accept": "application/vnd.microsoft.appconfig.kv\u002bjson",
"Authorization": "Sanitized",
"Content-Type": "application/json",
"Date": "Mon, 20 May 2019 18:32:36 GMT",
"Date": "Tue, 21 May 2019 17:38:30 GMT",
"If-None-Match": "*",
"User-Agent": [
"azsdk-net-config/1.0.0.0",
"(.NET Core 4.6.27617.04; Microsoft Windows 10.0.16299 )"
],
"x-ms-client-request-id": "b684458c-1855-4510-b88f-d01f0b6761b6",
"x-ms-client-request-id": "08a9a5eac4a7c6e4a035e4bc2a93985f",
"x-ms-content-sha256": "b11OQu6GthUatwGXUIKHHSRVyik0TdrUk5kZm3yZd2A=",
"x-ms-return-client-request-id": "true"
},
Expand All @@ -29,20 +29,20 @@
"ResponseHeaders": {
"Connection": "keep-alive",
"Content-Type": "application/vnd.microsoft.appconfig.kv\u002bjson; charset=utf-8",
"Date": "Mon, 20 May 2019 18:32:36 GMT",
"ETag": "\u0022OlSMSKlANJqCCFuE9n2gfoBKoZ8\u0022",
"Last-Modified": "Mon, 20 May 2019 18:32:37 GMT",
"Date": "Tue, 21 May 2019 17:38:30 GMT",
"ETag": "\u0022pLaLL6tAFtAaI3GIy6B2BkHqyDj\u0022",
"Last-Modified": "Tue, 21 May 2019 17:38:31 GMT",
"Server": "nginx/1.13.9",
"Strict-Transport-Security": "max-age=15724800; includeSubDomains;",
"Sync-Token": "zAJw6V16=NDotMSMxOTYwMzU=;sn=196035",
"Sync-Token": "zAJw6V16=NDotMSMxOTc5MTg=;sn=197918",
"Transfer-Encoding": "chunked",
"x-ms-client-request-id": "b684458c-1855-4510-b88f-d01f0b6761b6",
"x-ms-correlation-request-id": "7b1e1d44-5429-4b44-b5a3-bd9ea6bcec8f",
"x-ms-request-id": "7b1e1d44-5429-4b44-b5a3-bd9ea6bcec8f"
"x-ms-client-request-id": "08a9a5eac4a7c6e4a035e4bc2a93985f",
"x-ms-correlation-request-id": "320fc7c3-9849-4225-b4a9-8ffa222d126f",
"x-ms-request-id": "320fc7c3-9849-4225-b4a9-8ffa222d126f"
},
"ResponseBody": {
"etag": "OlSMSKlANJqCCFuE9n2gfoBKoZ8",
"key": "key-1269329324",
"etag": "pLaLL6tAFtAaI3GIy6B2BkHqyDj",
"key": "key-314090486",
"label": "test_label",
"content_type": "test_content_type",
"value": "test_value",
Expand All @@ -51,23 +51,23 @@
"tag2": "value2"
},
"locked": false,
"last_modified": "2019-05-20T18:32:37\u002b00:00"
"last_modified": "2019-05-21T17:38:31\u002b00:00"
}
},
{
"RequestUri": "https://pakrym-azconfig-ui.azconfig.io/kv/key-1269329324?label=test_label",
"RequestUri": "https://pakrym-azconfig-ui.azconfig.io/kv/key-314090486?label=test_label",
"RequestMethod": "PUT",
"RequestHeaders": {
"Accept": "application/vnd.microsoft.appconfig.kv\u002bjson",
"Authorization": "Sanitized",
"Content-Type": "application/json",
"Date": "Mon, 20 May 2019 18:32:36 GMT",
"Date": "Tue, 21 May 2019 17:38:30 GMT",
"If-None-Match": "*",
"User-Agent": [
"azsdk-net-config/1.0.0.0",
"(.NET Core 4.6.27617.04; Microsoft Windows 10.0.16299 )"
],
"x-ms-client-request-id": "d6d5d7aa-a68b-4a42-8b8a-019da13efa31",
"x-ms-client-request-id": "0edf752ddf45b6dd19639ea185f3f575",
"x-ms-content-sha256": "b11OQu6GthUatwGXUIKHHSRVyik0TdrUk5kZm3yZd2A=",
"x-ms-return-client-request-id": "true"
},
Expand All @@ -83,26 +83,26 @@
"ResponseHeaders": {
"Connection": "keep-alive",
"Content-Length": "0",
"Date": "Mon, 20 May 2019 18:32:36 GMT",
"Date": "Tue, 21 May 2019 17:38:30 GMT",
"Server": "nginx/1.13.9",
"Strict-Transport-Security": "max-age=15724800; includeSubDomains;",
"x-ms-client-request-id": "d6d5d7aa-a68b-4a42-8b8a-019da13efa31",
"x-ms-correlation-request-id": "7a207b74-050c-4c2d-8326-6099cf98882a",
"x-ms-request-id": "7a207b74-050c-4c2d-8326-6099cf98882a"
"x-ms-client-request-id": "0edf752ddf45b6dd19639ea185f3f575",
"x-ms-correlation-request-id": "27347042-e22d-460f-988a-4804d8c2260c",
"x-ms-request-id": "27347042-e22d-460f-988a-4804d8c2260c"
},
"ResponseBody": null
},
{
"RequestUri": "https://pakrym-azconfig-ui.azconfig.io/kv/key-1269329324?label=test_label",
"RequestUri": "https://pakrym-azconfig-ui.azconfig.io/kv/key-314090486?label=test_label",
"RequestMethod": "DELETE",
"RequestHeaders": {
"Authorization": "Sanitized",
"Date": "Mon, 20 May 2019 18:32:36 GMT",
"Date": "Tue, 21 May 2019 17:38:30 GMT",
"User-Agent": [
"azsdk-net-config/1.0.0.0",
"(.NET Core 4.6.27617.04; Microsoft Windows 10.0.16299 )"
],
"x-ms-client-request-id": "2dc1e445-63fd-4cae-a13d-6e2c9880b5ae",
"x-ms-client-request-id": "d6e35edfd2036d208de22d2e305231c3",
"x-ms-content-sha256": "47DEQpj8HBSa\u002b/TImW\u002b5JCeuQeRkm5NMpJWZG3hSuFU=",
"x-ms-return-client-request-id": "true"
},
Expand All @@ -111,20 +111,20 @@
"ResponseHeaders": {
"Connection": "keep-alive",
"Content-Type": "application/vnd.microsoft.appconfig.kv\u002bjson; charset=utf-8",
"Date": "Mon, 20 May 2019 18:32:37 GMT",
"ETag": "\u0022OlSMSKlANJqCCFuE9n2gfoBKoZ8\u0022",
"Last-Modified": "Mon, 20 May 2019 18:32:37 GMT",
"Date": "Tue, 21 May 2019 17:38:30 GMT",
"ETag": "\u0022pLaLL6tAFtAaI3GIy6B2BkHqyDj\u0022",
"Last-Modified": "Tue, 21 May 2019 17:38:31 GMT",
"Server": "nginx/1.13.9",
"Strict-Transport-Security": "max-age=15724800; includeSubDomains;",
"Sync-Token": "zAJw6V16=NDotMSMxOTYwMzY=;sn=196036",
"Sync-Token": "zAJw6V16=NDotMSMxOTc5MTk=;sn=197919",
"Transfer-Encoding": "chunked",
"x-ms-client-request-id": "2dc1e445-63fd-4cae-a13d-6e2c9880b5ae",
"x-ms-correlation-request-id": "1d322e70-495f-4802-bce9-032dc41ab63b",
"x-ms-request-id": "1d322e70-495f-4802-bce9-032dc41ab63b"
"x-ms-client-request-id": "d6e35edfd2036d208de22d2e305231c3",
"x-ms-correlation-request-id": "6d320f62-0d18-40a9-807e-43ce513dcc30",
"x-ms-request-id": "6d320f62-0d18-40a9-807e-43ce513dcc30"
},
"ResponseBody": {
"etag": "OlSMSKlANJqCCFuE9n2gfoBKoZ8",
"key": "key-1269329324",
"etag": "pLaLL6tAFtAaI3GIy6B2BkHqyDj",
"key": "key-314090486",
"label": "test_label",
"content_type": "test_content_type",
"value": "test_value",
Expand All @@ -133,12 +133,12 @@
"tag2": "value2"
},
"locked": false,
"last_modified": "2019-05-20T18:32:37\u002b00:00"
"last_modified": "2019-05-21T17:38:31\u002b00:00"
}
}
],
"Variables": {
"APP_CONFIG_CONNECTION": "Endpoint=https://pakrym-azconfig-ui.azconfig.io;Id=0-l1-s0:h5pHKElA5IjSL3z\u002bFOYz;Secret=;",
"RandomSeed": "2033108142"
"RandomSeed": "38241668"
}
}
Loading