[Cogs OCR] Update vision SDK per latest update from REST sepc #6310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toothache
commented
May 17, 2019
| @@ -1195,7 +1195,7 @@ public async Task<HttpOperationResponse<DomainModelResults>> AnalyzeImageByDomai | |||
| /// <return> | |||
| /// A response object containing the response body and response headers. | |||
| /// </return> | |||
| public async Task<HttpOperationResponse<OcrResult>> RecognizePrintedTextWithHttpMessagesAsync(bool detectOrientation, string url, OcrLanguages language = default(OcrLanguages), Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken)) | |||
| public async Task<HttpOperationResponse<OcrResult>> RecognizePrintedTextWithHttpMessagesAsync(bool detectOrientation, string url, OcrLanguages? language = default(OcrLanguages?), Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken)) | |||
There was a problem hiding this comment.
No swagger change for this API, so it seems that this change is caused by the autorest tool change.
toothache
commented
May 17, 2019
| @@ -3731,7 +3723,7 @@ public async Task<HttpOperationResponse<DomainModelResults>> AnalyzeImageByDomai | |||
| /// <return> | |||
| /// A response object containing the response body and response headers. | |||
| /// </return> | |||
| public async Task<HttpOperationResponse<OcrResult>> RecognizePrintedTextInStreamWithHttpMessagesAsync(bool detectOrientation, Stream image, OcrLanguages language = default(OcrLanguages), Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken)) | |||
| public async Task<HttpOperationResponse<OcrResult>> RecognizePrintedTextInStreamWithHttpMessagesAsync(bool detectOrientation, Stream image, OcrLanguages? language = default(OcrLanguages?), Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken)) | |||
There was a problem hiding this comment.
Same for this API. Seems to be caused by codegen tool.
|
|
|
@AlexGhiondea , we currently have a S3 issue related with this fix. And we need to fix the bug and release a new sdk before 5.31. Can you help review the change? |
sdk/cognitiveservices/Vision.ComputerVision/src/Generated/ComputerVisionClient.cs
Show resolved
Hide resolved
|
I am seeing a few API changes (removing parameters) -- are those breaking changes? |
AlexGhiondea
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update vision SDK per latest update from REST sepc:
generate.ps1script is not working per [BUG] Code generation script is not working after cognitive service folder structure is changed #6309, so run code generation for Vision SDK manually;TextRecognitionModeparameter is removed fromBatchReadFileOCR operation in the latest version and is thus a breaking change. So bump the major number for Vision SDK;BatchReadFile.