-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event Hubs SDK: Adding connection string support for AAD Managed Identity #6287
Event Hubs SDK: Adding connection string support for AAD Managed Identity #6287
Conversation
serkantkaraca
commented
May 15, 2019
- Adding connection string support for AAD Managed Identity
- Removing dependency on ADAL
sdk/eventhub/Microsoft.Azure.EventHubs/src/Primitives/AzureActiveDirectoryTokenProvider.cs
Outdated
Show resolved
Hide resolved
sdk/eventhub/Microsoft.Azure.EventHubs/src/Primitives/EventHubsConnectionStringBuilder.cs
Outdated
Show resolved
Hide resolved
sdk/eventhub/Microsoft.Azure.EventHubs/src/Amqp/AmqpEventHubClient.cs
Outdated
Show resolved
Hide resolved
sdk/eventhub/Microsoft.Azure.EventHubs/src/Amqp/AmqpEventHubClient.cs
Outdated
Show resolved
Hide resolved
sdk/eventhub/Microsoft.Azure.EventHubs/src/Microsoft.Azure.EventHubs.csproj
Show resolved
Hide resolved
sdk/eventhub/Microsoft.Azure.EventHubs/src/Microsoft.Azure.EventHubs.csproj
Show resolved
Hide resolved
sdk/eventhub/Microsoft.Azure.EventHubs/src/Primitives/EventHubsConnectionStringBuilder.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3 the use of the ITokenProvider! I approve.
@schaabs, do you have any guidance to impart for future Azure.Identity integration?
We discussed this last week. The callback pattern that they are using here aligns well with future plans for azure identity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were a couple of minor suggestions that I left, but otherwise, things look good to me.
/// <param name="audience">The service resource URI for token acquisition.</param> | ||
/// <param name="authority">Address of the authority to issue token.</param> | ||
/// <param name="state">State to be delivered to callback.</param> | ||
/// <returns></returns> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: If this won't be populated, better to remove it to reduce noise.
@@ -62,7 +63,7 @@ public static EventHubClient CreateFromConnectionString(string connectionString) | |||
/// <param name="operationTimeout">Operation timeout for Event Hubs operations.</param> | |||
/// <param name="transportType">Transport type on connection.</param> | |||
/// <returns></returns> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: If this won't be populated, better to remove it to reduce noise.