[Engineering System] Increase Timeout for Live Tests #6129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weshaggard
approved these changes
May 6, 2019
Due to the current state of the Event Hubs test suite, a live test run for a given platform is taking roughly 90 minutes on average. Because Windows is running two target platforms, the test run has been averaging roughly 2 hours and 30 minutes. The last couple of days have seen the Windows tests fail to complete in the allowed timeout window, surpassing the 155 minute mark, though it is believed that they would have completed if given another 5 minutes. Until we're able to refactor the Event Hubs tests for test timings, isolation, and parallelization, adjusting the timeout to allow nightly runs to complete without timing out.
e200d71 to
b0419a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The last couple of days have seen the Windows tests fail to complete in the allowed timeout window, surpassing the 155 minute mark, though it is believed that they would have completed if given another 5 minutes. I'd like to increase the timeout value once more to give them a bit of extra cushion and allow the runs to complete.
We recognize that this is not ideal and continue to have plans to enhance the suite with better isolation, durability, and to support parallelization, though the timeline to address this is not yet clear.
Last Upstream Rebase
Monday, May 6, 2019 2:28pm (EDT)