Event Grid data plane SDK: Update mappings in consumption SDK to include recently added EventGrid event types #6086
Conversation
…s, ContainerRegistry, AppConfiguration, and IoT.
|
@dsgouda , @AlexGhiondea : Can one of you please help review this PR? We need to release this updated SDK this week, hence need your help to review and approve this. |
| @@ -2,10 +2,10 @@ | |||
| <PropertyGroup> | |||
| <AssemblyTitle>Microsoft Azure EventGrid Library</AssemblyTitle> | |||
| <Description>This library can be used to publish events to Azure Event Grid and to consume events delivered by EventGrid. It also defines the event schemas for the events published to EventGrid by various Azure services. </Description> | |||
| <VersionPrefix>3.0.0</VersionPrefix> | |||
| <VersionPrefix>3.2.0</VersionPrefix> | |||
There was a problem hiding this comment.
Why did we skip 3.1.0?
There was a problem hiding this comment.
When I checked NuGet, It looks like there's already a 3.1.0 version released (https://www.nuget.org/packages/Microsoft.Azure.EventGrid/3.1.0) 1 month back. However, 13 days back the SDK team moved the data plane files from src/sdks to sdk directory, and it looks like as part of that the version checked in into this CSPROJ reverted back to 3.0.0. Hence, I moved the version to 3.2.0.
There was a problem hiding this comment.
/cc @weshaggard @chidozieononiwu @kurtzeborn for the issues with the move of the library.
There was a problem hiding this comment.
As part of the move @chidozieononiwu did in #6001 it looks like there were conflicting versions the AssemblyVersion was 3.0.0.0 and the PackageVersion was 3.1.0 and we incorrectly picked 3.0.0 instead of 3.1.0 as we should have. So it is correct to go to 3.2.0 now.
|
@AlexGhiondea , can you please take a look at my responses above? Please let me know if you need any more information and/or if you have any additional comments on this RP. |
| <PackageReleaseNotes>Added support for the new Azure Media Services event types for tracking state changes of Media Jobs and Media JobOutputs. The existing MediaJobStateChangeEvent can be used to get all state change events for a Job but there are now separate events for each state like MediaJobScheduledEvent, MediaJobFinishedEvent, etc. These allow subscribing for just the desired events. Likewise a MediaJobOutputStateChangeEvent was added to get events for all MediaJobOutput state changes along with individual events for each JobOutput state. MediaJobOutputProgressEvent was added to get events for Job output progress value, label and correlation data. This change also adds support for events related to Media LiveEvents to get notifications related to the ingestion of live streams (encoder connected, encoder disconnected, discontinuity, chunk dropped, etc). Note JobState was renamed to MediaJobState to follow the Media prefix that all of the other Media Services Event classes use. This is a breaking change, albeit a small one.</PackageReleaseNotes> | ||
| <AzureApiTag>EventGrid_2019-02-01-preview;</AzureApiTag> | ||
| <PackageReleaseNotes>Support for additional Azure event types from ContainerRegistry, AppConfiguration, Maps and IoTHub services. Also, updated the consumption SDK to make it easier to consume these new event schemas.</PackageReleaseNotes> | ||
| <AzureApiTag>EventGrid_2018-01-01;</AzureApiTag> |
There was a problem hiding this comment.
Does this mean that we are going back to supporting an older version of the service? Is that going to cause issues when people upgrade from 3.0.0 to 3.2.0?
There was a problem hiding this comment.
For the dataplane/runtime of the EventGrid service, the latest API version is 2018-01-01. For the management plane, the latest API version is 2019-02-01-preview. This is the DataPlane SDK, however somehow the AzureApiTag was mentioned as EventGrid_2019-02-01-preview which is the control plane's API version, hence as part of this PR, I fixed/updated it to reflect the data plane's latest API version.
|
/azp run azure-sdk-for-net - mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - hdinsight - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Event Grid data plane SDK: Update mappings in consumption SDK to include recently added EventGrid event types from AppConfiguration, ContainerRegistry, Maps, and IoTHub services.