-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure Search] Add new skill and cognitive services attachment to SDK #5223
Conversation
Does marking properties/methods/members constitute as a breaking change? |
@arv100kri Do you mean marking members with |
...aPlane/Microsoft.Azure.Search.Service/Customizations/Skillsets/Models/NamedEntityCategory.cs
Outdated
Show resolved
Hide resolved
....Azure.Search.Service/Customizations/Skillsets/Models/NamedEntityRecognitionSkillLanguage.cs
Outdated
Show resolved
Hide resolved
src/SDKs/Search/DataPlane/Microsoft.Azure.Search.Service/Generated/SkillsetsOperations.cs
Outdated
Show resolved
Hide resolved
...aPlane/Microsoft.Azure.Search.Service/Customizations/Skillsets/Models/NamedEntityCategory.cs
Outdated
Show resolved
Hide resolved
...earch/DataPlane/Microsoft.Azure.Search.Common/Customizations/Search/Models/ExtensibleEnum.cs
Outdated
Show resolved
Hide resolved
...DataPlane/Microsoft.Azure.Search.Service/Customizations/DataSources/Models/DataSourceType.cs
Show resolved
Hide resolved
...icrosoft.Azure.Search.Service/Customizations/Indexers/Models/IndexingParametersExtensions.cs
Outdated
Show resolved
Hide resolved
Yup, and thanks for clarifying! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, just a few more minor changes
src/SDKs/Search/DataPlane/Search.Tests/Tests/ExtensibleEnumTests.cs
Outdated
Show resolved
Hide resolved
...DataPlane/Microsoft.Azure.Search.Service/Customizations/DataSources/Models/DataSourceType.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still confused by the tests :(
Description
EntityRecognitionSkill
and the ability to attach cognitive services to a skillset - this is from the REST spec merged via this PRNamedEntityRecognitionSkill
as deprecatedCosmosDb
data source creation method, to address Azure Search SDK: Missing CosmosDb data source creation methods #5060 and markDocumentDb
method as deprecatedjsonLines
indexer parsing mode which was recently introduced in the REST APIThis checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK.