Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Search] Add new skill and cognitive services attachment to SDK #5223

Merged
merged 15 commits into from
Feb 15, 2019
Merged

[Azure Search] Add new skill and cognitive services attachment to SDK #5223

merged 15 commits into from
Feb 15, 2019

Conversation

arv100kri
Copy link
Member

@arv100kri arv100kri commented Feb 9, 2019

Description

  • Regenerate the SDK to generate code for EntityRecognitionSkill and the ability to attach cognitive services to a skillset - this is from the REST spec merged via this PR
  • Mark NamedEntityRecognitionSkill as deprecated
  • Add a CosmosDb data source creation method, to address Azure Search SDK: Missing CosmosDb data source creation methods #5060 and mark DocumentDb method as deprecated
  • Expose the jsonLines indexer parsing mode which was recently introduced in the REST API
  • Update tests for skills, skillsets and data sources

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@arv100kri
Copy link
Member Author

Does marking properties/methods/members constitute as a breaking change?
It shouldn't matter anyway, I think because we have bumped up the version number anyway, correct?

@arv100kri arv100kri changed the title Add new skill and cognitive services attachment to SDK [Azure Search] Add new skill and cognitive services attachment to SDK Feb 9, 2019
@arv100kri arv100kri requested a review from mgottein February 12, 2019 18:42
@brjohnstmsft
Copy link
Member

@arv100kri Do you mean marking members with [Obsolete]? That isn't a breaking change in and of itself. And you're right; It doesn't matter anyway because we've bumped the major version number in anticipation of breaking changes for Complex Types.

@arv100kri
Copy link
Member Author

@arv100kri Do you mean marking members with [Obsolete]? That isn't a breaking change in and of itself. And you're right; It doesn't matter anyway because we've bumped the major version number in anticipation of breaking changes for Complex Types.

Yup, and thanks for clarifying!

Copy link
Member

@brjohnstmsft brjohnstmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, just a few more minor changes

Copy link
Member

@brjohnstmsft brjohnstmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still confused by the tests :(

@brjohnstmsft brjohnstmsft self-assigned this Feb 15, 2019
@arv100kri arv100kri merged commit f638f01 into Azure:search-preview Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants