Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playwrighttesting): separate api, test data processing and utility layers #46681

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ Ensure that the `PLAYWRIGHT_SERVICE_URL` that you obtained in previous step is a
Run Playwright tests against browsers managed by the service using the configuration you created above.

```dotnetcli
dotnet test --logger "ms-playwright-service"
dotnet test --logger "microsoft-playwright-testing"
```

## Key concepts
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ This guide explains the different options available to you in the Azure.Develope
<Parameter name="Os" value="linux" />
<Parameter name="RunId" value="sample-run-id" />
<Parameter name="ExposeNetwork" value="<loopback>" />
<Parameter name="ServiceAuth" value="EntraId" />
<Parameter name="ServiceAuthType" value="EntraId" />
<Parameter name="UseCloudHostedBrowsers" value="true" />
<Parameter name="AzureTokenCredentialType" value="DefaultAzureCredential" />
<Parameter name="ManagedIdentityClientId" value="77bfc267-86cb-4eeb-9e4a-747a217a318c" />
Expand Down Expand Up @@ -79,7 +79,7 @@ public class PlaywrightServiceSetup : PlaywrightServiceNUnit
3. **`ExposeNetwork`**:
- **Description**: This settings exposes network available on the connecting client to the browser being connected to.

4. **`ServiceAuth`**
4. **`ServiceAuthType`**
- **Description**: This setting allows you to specify the default authentication mechanism to be used for sending requests to the service.
- **Available Options**:
- `ServiceAuthType.EntraId` for Microsoft Entra ID authentication.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public class PlaywrightServiceSetup : PlaywrightServiceNUnit {};
<RunSettings>
<TestRunParameters>
<!-- Set the service auth type as AccessToken -->
<Parameter name="ServiceAuth" value="AccessToken" />
<Parameter name="ServiceAuthType" value="AccessToken" />
</TestRunParameters>
</RunSettings>
```
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@ namespace Azure.Developer.MicrosoftPlaywrightTesting.TestLogger.Client
{
public partial class TestReportingClientOptions : Azure.Core.ClientOptions
{
public TestReportingClientOptions(Azure.Developer.MicrosoftPlaywrightTesting.TestLogger.Client.TestReportingClientOptions.ServiceVersion version = Azure.Developer.MicrosoftPlaywrightTesting.TestLogger.Client.TestReportingClientOptions.ServiceVersion.V2024_05_20_Preview) { }
public TestReportingClientOptions(Azure.Developer.MicrosoftPlaywrightTesting.TestLogger.Client.TestReportingClientOptions.ServiceVersion version = Azure.Developer.MicrosoftPlaywrightTesting.TestLogger.Client.TestReportingClientOptions.ServiceVersion.V2024_09_01_Preview) { }
public enum ServiceVersion
{
V2024_05_20_Preview = 1,
V2024_09_01_Preview = 1,
}
}
}

This file was deleted.

Loading