Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] Test hang fix #43216

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

jsquire
Copy link
Member

@jsquire jsquire commented Apr 4, 2024

Summary

The focus of these changes is to fix a typo causing a test to hang indefinitely. The assertions in this test were causing an exception that prevented the handler from running, which in turn caused the exit condition to never be met.

The focus of these changes is to fix a typo causing
a test to hang indefinitely. The assertions in this
test were causing an exception that prevented the
handler from running, which in turn caused the exit
condition to never be met.
@jsquire jsquire added Service Bus Client This issue points to a problem in the data-plane of the library. test-reliability Issue that causes tests to be unreliable labels Apr 4, 2024
@jsquire jsquire added this to the 2024-04 milestone Apr 4, 2024
@jsquire jsquire self-assigned this Apr 4, 2024
@jsquire
Copy link
Member Author

jsquire commented Apr 4, 2024

/azp run net - servicebus - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@m-redding m-redding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh thanks for fixing this. I was running into this in the pipelines on Tuesday but wasn't able to figure out what was wrong since everything was passing on my end.

@jsquire jsquire merged commit af1b31c into Azure:main Apr 5, 2024
47 checks passed
@jsquire jsquire deleted the servicebus/test-testing branch April 5, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus test-reliability Issue that causes tests to be unreliable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants