Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientModel: Make message.Apply(options) take nullable options #43212

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

annelo-msft
Copy link
Member

Based on feedback and discussion around Azure/autorest.csharp#4502

Copy link
Member

@m-nash m-nash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add a link to the follow up to adjust the generated code to avoid the null check after this goes live.

@annelo-msft annelo-msft marked this pull request as ready for review April 4, 2024 20:47
@annelo-msft annelo-msft requested review from KrzysztofCwalina, tg-msft and a team as code owners April 4, 2024 20:47
@annelo-msft annelo-msft enabled auto-merge (squash) April 4, 2024 20:47
@annelo-msft annelo-msft merged commit b87f7ad into Azure:main Apr 4, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants