[Event Hubs] ETW fixes #43210
Merged
[Event Hubs] ETW fixes #43210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The focus of these changes is to fix several mistakes related to ETW logs. Some messages that included links to the troubleshooting guide were improperly annotated with `[Event]` instead of `[NonEvent]`, causing ETW to log a warning for "too many parameters" when writing the messages. Also corrected a parameter ordering issue for an event batch processing error, causing the structured argument parameters to be ordered differently than they appear in the message template.
|
/azp run net - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
christothes
reviewed
Apr 4, 2024
sdk/eventhub/Azure.Messaging.EventHubs/src/Diagnostics/EventHubsEventSource.cs
Show resolved
Hide resolved
christothes
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to fix several mistakes related to ETW logs. Some messages that included links to the troubleshooting guide were improperly annotated with
[Event]instead of[NonEvent], causing ETW to log a warning for "too many parameters" when writing the messages. Also corrected a parameter ordering issue for an event batch processing error, causing the structured argument parameters to be ordered differently than they appear in the message template.