Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AppConfiguration] Implemented Etag/page feature with an AsPages extension method #43205

Merged
merged 7 commits into from
Apr 5, 2024
Merged

[AppConfiguration] Implemented Etag/page feature with an AsPages extension method #43205

merged 7 commits into from
Apr 5, 2024

Conversation

kinelski
Copy link
Member

@kinelski kinelski commented Apr 4, 2024 •
edited
Loading

Based on architect feedback, the SettingSelector.MatchConditions property was removed and replaced with an AsPages extension method.

New usage is:

foreach (Page<ConfigurationSetting> page in service.GetConfigurationSettings(selector).AsPages(matchConditionsList))
{
}

@kinelski kinelski self-assigned this Apr 4, 2024
@kinelski kinelski added Client This issue points to a problem in the data-plane of the library. App Configuration Azure.ApplicationModel.Configuration labels Apr 4, 2024
@kinelski kinelski marked this pull request as ready for review April 4, 2024 18:39
tg-msft
tg-msft approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@tg-msft tg-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how clean the API ended up! I left a couple of questions and nits, but it looks great overall.

kinelski and others added 6 commits April 5, 2024 08:03
@kinelski @tg-msft
Update sdk/appconfiguration/Azure.Data.AppConfiguration/src/Pageable/…
183b885 
…ConditionalPageableImplementation.cs

Co-authored-by: tg-msft <tg-msft@users.noreply.github.com>
@kinelski @tg-msft
Update sdk/appconfiguration/Azure.Data.AppConfiguration/src/Pageable/…
7d78279 
…AsyncConditionalPageable.cs

Co-authored-by: tg-msft <tg-msft@users.noreply.github.com>
@kinelski
Addressing PR feedback
3a70b65
@kinelski
Address PR feedback 2
91c8228
@kinelski @tg-msft
Update sdk/appconfiguration/Azure.Data.AppConfiguration/src/Pageable/…
f2ca1ec 
…ConditionalPageableImplementation.cs

Co-authored-by: tg-msft <tg-msft@users.noreply.github.com>
@kinelski
Address PR feedback 3
4497f06
@kinelski kinelski merged commit 7aacf42 into Azure:main Apr 5, 2024
17 checks passed
@kinelski kinelski deleted the ac-aspages branch April 5, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsquire jsquire jsquire approved these changes

@tg-msft tg-msft tg-msft approved these changes

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina

@ShivangiReja ShivangiReja Awaiting requested review from ShivangiReja

@pallavit pallavit Awaiting requested review from pallavit

Assignees

@kinelski kinelski

Labels
App Configuration Azure.ApplicationModel.Configuration Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kinelski @jsquire @tg-msft