Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Search] Prepare for Autocomplete API and merge from GA branch #4283

Merged
merged 2 commits into from
May 4, 2018

Conversation

brjohnstmsft
Copy link
Member

@brjohnstmsft brjohnstmsft commented May 3, 2018

Description

See individual commits for details.

FYI @mhko @Yahnoosh

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

This is necessary because the new Autocomplete API requires adding a new
method to an existing interface, which is technically a breaking change in
.NET. Also, version 5 now points to a different REST API version, and we don't
want to allow mixing versions in the same application.

This also updates the release notes to reflect that Synonyms is out of preview
and Autocomplete is in.
@brjohnstmsft brjohnstmsft requested a review from mhko May 3, 2018 03:32
@mhko
Copy link
Member

mhko commented May 3, 2018

}

You will update this in a separate PR?


Refers to: src/SDKs/Search/DataPlane/Microsoft.Azure.Search.Data/Properties/AssemblyInfo.cs:22 in 23c4528. [](commit_id = 23c4528, deletion_comment = False)

Copy link
Member

@mhko mhko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my question about the target api-version.

@dsgouda
Copy link
Contributor

dsgouda commented May 3, 2018

@azuresdkci retest this please

@brjohnstmsft
Copy link
Member Author

@mhko Yes, as discussed we will bump the REST API version too.

@brjohnstmsft
Copy link
Member Author

@dsgouda @shahabhijeet Any idea what this "default" check is that is blocking merge? There's no "Details" link to click on. Is this a configuration issue with this branch?

@dsgouda
Copy link
Contributor

dsgouda commented May 3, 2018

@brjohnstmsft I can merge if you are ready

@brjohnstmsft
Copy link
Member Author

@dsgouda Yes, please merge. I'll make the suggested changes in a subsequent PR.

Do you know why it won't let me merge though? @shahabhijeet should have set my team up with push access to this branch.

@dsgouda dsgouda merged commit b188e42 into Azure:search-preview May 4, 2018
@brjohnstmsft brjohnstmsft deleted the apply-ga-fixes branch May 9, 2018 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants