-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure Search] Prepare for Autocomplete API and merge from GA branch #4283
Conversation
This is necessary because the new Autocomplete API requires adding a new method to an existing interface, which is technically a breaking change in .NET. Also, version 5 now points to a different REST API version, and we don't want to allow mixing versions in the same application. This also updates the release notes to reflect that Synonyms is out of preview and Autocomplete is in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my question about the target api-version.
@azuresdkci retest this please |
@mhko Yes, as discussed we will bump the REST API version too. |
@dsgouda @shahabhijeet Any idea what this "default" check is that is blocking merge? There's no "Details" link to click on. Is this a configuration issue with this branch? |
@brjohnstmsft I can merge if you are ready |
@dsgouda Yes, please merge. I'll make the suggested changes in a subsequent PR. Do you know why it won't let me merge though? @shahabhijeet should have set my team up with push access to this branch. |
Description
See individual commits for details.
FYI @mhko @Yahnoosh
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK.