Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS][CallAutomation]Move SourceCallerIdNumber from Answer to Transfer api #42642

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

fangchen0601
Copy link
Contributor

@fangchen0601 fangchen0601 commented Mar 12, 2024

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

  1. Run autorest to updated a lot models include media teams work
  2. In CallMedia.cs, StartHoldMusicAsync and StartHoldMusic is updated to pass the build and left comment for media team to work on the StartHoldMusicOptions.Loop and operationCallbackUri
  3. Move SourceCallerIdNumber from Answer to Transfer api

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Communication.CallAutomation

@minwoolee-msft minwoolee-msft merged commit 65318e9 into main Mar 12, 2024
16 checks passed
@minwoolee-msft minwoolee-msft deleted the fangchen0601/transfer_source_caller_id branch March 12, 2024 23:01
angiurgiu pushed a commit that referenced this pull request Mar 20, 2024
…r api (#42642)

* remove SourceCallerIdNumber from answercallOptions, update autorest with new swagger

* create internal classes for media feature and ops feature models

* update api

* add SourceCallIdNumber to Transfer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants