-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebasing .NET SDK To Version 1.31.1 With Instance Failover Group APIs #4257
Rebasing .NET SDK To Version 1.31.1 With Instance Failover Group APIs #4257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great other than release notes. Thx
@@ -7,7 +7,7 @@ | |||
<PackageId>Microsoft.Azure.Management.Sql</PackageId> | |||
<Description>Azure SQL Management SDK library</Description> | |||
<AssemblyName>Microsoft.Azure.Management.Sql</AssemblyName> | |||
<Version>1.13.0-preview</Version> | |||
<Version>1.13.1-preview</Version> | |||
<PackageTags>Microsoft Azure SQL Management;SQL;SQL Management;</PackageTags> | |||
<PackageReleaseNotes> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete the current release notes and add new release notes:
- Added support for Managed Instances, Managed Instance databases, and Managed Instance failover groups.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jared. I have update the release note now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Will merge once CI passes |
@ziwa-msft while you are at it, please pull down the latest changes from upstream and run the code generation again (the txt file should not be displayed as a binary on the PR) |
Description
I have rebased the .Net SDK to 1.13.1 by cherrypicking changes for InstanceFailoverGroup on top of the 1.13.0 branch.
The files are generated by targeting composite v2 APIs. Link to swagger template: ziwa-msft/azure-rest-api-specs@b2b5156
We have verified that all tests are passing locally.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK.