-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AzureMonitorDistro] Add ASP.NET Core and HTTP Client metrics instrumentation #42307
Merged
TimothyMothra
merged 27 commits into
Azure:main
from
rajkumar-rangaraj:rajrang/addInsMetrics
Mar 12, 2024
Merged
[AzureMonitorDistro] Add ASP.NET Core and HTTP Client metrics instrumentation #42307
TimothyMothra
merged 27 commits into
Azure:main
from
rajkumar-rangaraj:rajrang/addInsMetrics
Mar 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API change check API changes are not detected in this pull request. |
cijothomas
reviewed
Mar 1, 2024
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/OpenTelemetryBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
TimothyMothra
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. left a comment about fixing formatting of Readme
cijothomas
reviewed
Mar 11, 2024
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/CHANGELOG.md
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Mar 11, 2024
Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com>
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/CHANGELOG.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
reyang
reviewed
Mar 12, 2024
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/OpenTelemetryBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
reyang
reviewed
Mar 12, 2024
Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/CHANGELOG.md
Outdated
Show resolved
Hide resolved
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/CHANGELOG.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
vishweshbankwar
approved these changes
Mar 12, 2024
angiurgiu
pushed a commit
that referenced
this pull request
Mar 20, 2024
…entation (#42307) * Add ASP.NET Core and HTTP Client metrics instrumentation * Changelog update * Update .NET 8.0 and above to use built-in meter. * Update readme * readme - swich doc to use new api. * Update sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/README.md * Update sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/README.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/README.md Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com> * Update README.md * Update README.md * Update sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/CHANGELOG.md Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com> * Update README.md * Update README.md * Update README.md * Update OpenTelemetryBuilderExtensions.cs * Update sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/README.md Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com> * Update README.md * Update README.md * Update sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/CHANGELOG.md Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com> * Update sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/CHANGELOG.md Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com> * Update sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/README.md Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com> * Update sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/README.md Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com> --------- Co-authored-by: Timothy Mothra <tilee@microsoft.com> Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested manually, here are the newly created metrics.