Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA sdk release. #42278

Merged
merged 17 commits into from
Mar 14, 2024
Merged

GA sdk release. #42278

merged 17 commits into from
Mar 14, 2024

Conversation

wangbwn
Copy link
Member

@wangbwn wangbwn commented Feb 29, 2024

No description provided.

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Feb 29, 2024
Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangbwn :

Your account lacks write permissions to the repository, which is required before this PR can move forward. Please review the Azure SDK onboarding documentation and use the associated teams channel for assistance.

Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

@ruowan
Copy link
Member

ruowan commented Mar 4, 2024

@ruowan
Copy link
Member

ruowan commented Mar 4, 2024

@JoshLove-msft We are releasing the .NET GA version SDK. The CI failure report that
eng\Directory.Build.Common.targets(316,5): Error : When the project has a release version it shouldn't reference any pre-release libraries. Found the following pre-release references: Azure.Core.Expressions.DataFactory Seems we need to release a Azure.Core.Expression.DataFactory first and then release the ADF GA version .net SDK. Could you please help to take a look?

Copy link
Member

@ArthurMa1978 ArthurMa1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending on Josh release Azure.Core.Expressions.DataFactory first stable

@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 6, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.DataFactory

@jsquire jsquire dismissed their stale review March 6, 2024 15:41

Account issues have been corrected.

jsquire
jsquire previously requested changes Mar 6, 2024
Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wangbwn still requires write permissions to the repository for this PR to move forward.

@wangbwn
Copy link
Member Author

wangbwn commented Mar 12, 2024

Hi, @JoshLove-msft.
"I locally modified the version of Azure.Core.Expressions.DataFactory to '1.0.0', then regenerated the code. However, I found that the 'dotnet build /t:GenerateCode' command did not rename DataFactorySecretBaseDefinition to DataFactorySecret as expected."
image

@jsquire jsquire dismissed their stale review March 12, 2024 12:54

Account issues have been resolved.

@ArthurMa1978 ArthurMa1978 enabled auto-merge (squash) March 13, 2024 15:48
@ArthurMa1978 ArthurMa1978 disabled auto-merge March 13, 2024 23:44
@ArthurMa1978 ArthurMa1978 merged commit 7b10e4e into Azure:main Mar 14, 2024
31 checks passed
angiurgiu pushed a commit that referenced this pull request Mar 20, 2024
@wangbwn wangbwn deleted the vbw/GARelease branch April 1, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants