-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support overrides of token issuer from environment variables #41945
Merged
christothes
merged 26 commits into
main
from
hadhunna/supportIssureValidationFromSettingsFile
Mar 12, 2024
Merged
Support overrides of token issuer from environment variables #41945
christothes
merged 26 commits into
main
from
hadhunna/supportIssureValidationFromSettingsFile
Mar 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API change check APIView has identified API level changes in this PR and created following API reviews. |
@hakimms Tried adding you as a reviewer but your name isn't coming up. Can you give this a review please? |
hakimms
reviewed
Feb 14, 2024
...ft.Azure.WebJobs.Extensions.AuthenticationEvents/src/AuthenticationEventsTriggerAttribute.cs
Outdated
Show resolved
Hide resolved
...ft.Azure.WebJobs.Extensions.AuthenticationEvents/src/AuthenticationEventsTriggerAttribute.cs
Outdated
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
...a/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/tests/ConfigurationManagerTests.cs
Show resolved
Hide resolved
hakimms
approved these changes
Feb 14, 2024
...ticationEvents/api/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
…o hadhunna/supportIssureValidationFromSettingsFile
hakimms
reviewed
Feb 21, 2024
...a/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/tests/ConfigurationManagerTests.cs
Show resolved
Hide resolved
robezirg
reviewed
Feb 21, 2024
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
christothes
reviewed
Feb 23, 2024
...ft.Azure.WebJobs.Extensions.AuthenticationEvents/src/AuthenticationEventsTriggerAttribute.cs
Show resolved
Hide resolved
HarmanDhunna
commented
Feb 26, 2024
...ticationEvents/api/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents.netstandard2.0.cs
Show resolved
Hide resolved
robezirg
reviewed
Feb 26, 2024
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/ConfigurationManager.cs
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/ConfigurationManager.cs
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/TokenValidatorEZAuth.cs
Outdated
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/TokenValidatorInternal.cs
Outdated
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/TokenValidatorInternal.cs
Outdated
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/tests/TestHelper.cs
Outdated
Show resolved
Hide resolved
hakimms
reviewed
Feb 28, 2024
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/ConfigurationManager.cs
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/TokenValidatorEZAuth.cs
Outdated
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/TokenValidatorInternal.cs
Outdated
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/TokenValidatorInternal.cs
Outdated
Show resolved
Hide resolved
christothes
reviewed
Mar 4, 2024
...osoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/AuthenticationEventConfigProvider.cs
Outdated
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/CHANGELOG.md
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/TokenValidatorInternal.cs
Outdated
Show resolved
Hide resolved
hakimms
reviewed
Mar 5, 2024
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/TokenValidatorEZAuth.cs
Show resolved
Hide resolved
robezirg
approved these changes
Mar 6, 2024
...osoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/AuthenticationEventConfigProvider.cs
Show resolved
Hide resolved
christothes
approved these changes
Mar 7, 2024
hakimms
approved these changes
Mar 8, 2024
angiurgiu
pushed a commit
that referenced
this pull request
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr intends to add support for overrides of issuer for token validation.
Introducing new properties:
AuthenticationEvents__AuthorityUrl
AuthenticationEvents__AuthorizedPartyAppId
Removing:
AuthenticationEvents__TenantId
NOTE: This PR will break current API contract.
With the above combined with and
AuthenticationEvents__AudienceAppId
a developer can define their own application for token validation.Another property we are including is
AuthenticationEvents__ShowPIIDataInLogs
(false by default) which can only be configured as Environment Variable. This property allows the developer to see PII data in the logs. Currently we are only checking this flag for token validation, and logging PII data if token validation fails.There is no change to the API with this.
Example usages:
When setting it up in Azure Function Attributes:
When setting it up in Azure Function Environment variables:

End to End Validation:
[x] Success Scenario : 200


[x] No Access Token : 401
[x] Invalid AuthorityUrl: 401
[x] Invalid Audience: 401
[x] Invalid Authorized App Party ID: 401