-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ReleasePR Azure.Communication.JobRouter] Fix service name #39854
Closed
azure-sdk
wants to merge
1
commit into
Azure:main
from
azure-sdk:sdkAuto/Azure.Communication.JobRouter
Closed
[ReleasePR Azure.Communication.JobRouter] Fix service name #39854
azure-sdk
wants to merge
1
commit into
Azure:main
from
azure-sdk:sdkAuto/Azure.Communication.JobRouter
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ACS][JobRouter] GA Version (Azure#25763) * jobrouter ga typespec initial commit * add x-ms-example * change unknown to object * fix consumes for upsert routes * fix naming validation error * remove x-ms-examples * unreferenced json file validation fix * change to using unknown * rename generated client to XXXXXRestClient * test generating convenience methods * add line * rebased * correctly represent uri * try out standard operations for classification policy * use standard ops wherever possible * try placing route decorator at namespace level * remove router decorator from namespace * update tspconfig * add conditional headers * use azure core etag * fix floats to doubles * update typespec-python options + regenerate rest specs * fix lint errors * add examples * ci fixes 2 * ci fixes 3 * remove reference to Azure.Core.Etag (throws lint error) * review feedback * added list query params * try codegen without url scalar * retry python emitter with url fix * try specifying python output directory * python emitter - change package-mode to azure-dataplane * remove @example decorator * remove redundant imports * fix examples * make ScheduleAndSuspendMode.ScheduleAt a required field * uri scalar add * clean up * Update JS sdk config to azure-rest * change JobMatchingMode polymorphic type * rename client remove Rest * rename acceptJob, declineJob to acceptJobOffer, declineJobOffer * test internal decorator * make all upsert methods internal * specify python package version * Make upsert methods internal * make status selectors internal for python * sdk feedback review items * more review feedback items * update examples * Add partial-update for java * try updating client.tsp to rename method for .NET * make ExceptionAction.Id optional * run prettier * fix more examples * minor doc update * Update projected names and internal modifier * Modify internal to only apply for java, csharp, python * Update internal * make upsert method visible for python * modify enums for python * revert * sdk review comment 3 * Test generator without endpoint * Revert change * manually add empty response schemas in swagger because of Azure/azure-rest-api-specs#25605 (comment) * add linter in tspconfig.yaml * add to custom words * doc updates * fix nextlink lint error * test changes in client.tsp for validation failures * run cleanup * Update java internal models * Remove projectedName annotations * more linter fixes * exception action make id not readonly since needs to be serialized * make methods for canceljon, complete job, close job and decline offer internal so as to not expose empty response objects * update azure-tools/typespec-ts emitter options * try update example for LintDiff errors * set nextLink value to null * Update unassignJob internal csharp * move out assignmentId to path * linter fixes * Revert unassign job changes * Add internal for unassign csharp * use standard ResourceAction for all action except closeJob * fix linters * close job should always return 200 * fix linter errors * Suppress violation ValidFormats in LintDiff * test method rename * try rename again * try again * try again * try again * set default values for min and maz concurrent offer * set default value of bypass selectors * try codegen removing @route decorator * clean up @route decorator * revert making unassign internal for csharp * try renaming completeJob to completeJobInternal for csharp * rename op cancel, close, complete, decline for csharp * Add "where" clause to ValidFormats suppression * redefine empty model differently * fix spelling of primitive * Suppress INVALID_TYPE caused by bug in ModelValidation - Azure/azure-rest-api-specs#25381 * add default and change empty model representation * Make unassign job internal * linter fixes * Update specification/communication/Communication.JobRouter/models.tsp Co-authored-by: Mike Kistler <mikekistler@microsoft.com> * Update specification/communication/Communication.JobRouter/models.tsp Co-authored-by: Mike Kistler <mikekistler@microsoft.com> * linter fixes --------- Co-authored-by: Adam Tuck <adamtuck@microsoft.com> Co-authored-by: Marc Ma <marcma@microsoft.com> Co-authored-by: Charandeep Parisineti <cparisineti@microsoft.com> Co-authored-by: williamzhao87 <williamzhao87@gmail.com> Co-authored-by: Mike Harder <mharder@microsoft.com> Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create to sync Azure/azure-rest-api-specs#26749
ReCreate this PR