Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CA1825 suppression #35885

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Remove CA1825 suppression #35885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions sdk/keyvault/Azure.Security.KeyVault.Administration/src/KeyVaultSetting.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ namespace Azure.Security.KeyVault.Administration
/// </summary>
[CodeGenModel("Setting")]
[CodeGenSuppress(nameof(KeyVaultSetting), typeof(string), typeof(string))]
#pragma warning disable CA1825 // Avoid zero-length array allocations
[CodeGenSuppress("Content")]
#pragma warning restore CA1825 // Avoid zero-length array allocations
public partial class KeyVaultSetting
{
/// <summary>
Expand Down
4 changes: 2 additions & 2 deletions sdk/keyvault/Azure.Security.KeyVault.Keys/tests/CryptographyClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ public void SignDataAsyncArugmentValidation()
[Test]
public void VerifyDataAsyncArgumentValidation()
{
Assert.ThrowsAsync<ArgumentNullException>(() => Client.VerifyDataAsync(SignatureAlgorithm.ES256Value, (byte[])null, new byte[0]));
Assert.ThrowsAsync<ArgumentNullException>(() => Client.VerifyDataAsync(SignatureAlgorithm.ES256Value, (Stream)null, new byte[0]));
Assert.ThrowsAsync<ArgumentNullException>(() => Client.VerifyDataAsync(SignatureAlgorithm.ES256Value, (byte[])null, Array.Empty<byte>()));
Assert.ThrowsAsync<ArgumentNullException>(() => Client.VerifyDataAsync(SignatureAlgorithm.ES256Value, (Stream)null, Array.Empty<byte>()));
}
}
}