[Event Hubs] Update Perf/Stress Version #34863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The focus of these changes is to update the version of Event Hubs referenced for performance/stress testing.
AlexanderSher
approved these changes
Mar 12, 2023
weshaggard
reviewed
Mar 13, 2023
| @@ -186,7 +186,7 @@ | |||
| <PackageReference Update="ApprovalTests" Version="3.0.22" /> | |||
| <PackageReference Update="ApprovalUtilities" Version="3.0.22" /> | |||
| <PackageReference Update="Azure.Identity" Version="1.7.0" /> | |||
| <PackageReference Update="Azure.Messaging.EventHubs" Version="5.2.0" /> | |||
| <PackageReference Update="Azure.Messaging.EventHubs" Version="5.8.1" /> | |||
There was a problem hiding this comment.
Do we know why we need these versions to be different from the others listed above?
There was a problem hiding this comment.
We do not, and the existence of these overrides is something that we're discussing currently. I would like to see them go away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to update the version of Event Hubs referenced for performance/stress testing.