Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated SDK modules and recorded tests for UltraSSDCapability property in Dedicated Hosts for API version 2022-03-01 Compute #27949 #27984

Conversation

hari-bodicherla
Copy link
Contributor

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@grizzlytheodore
Copy link
Member

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Pull request contains merge conflicts.

/// <param name="zones">Availability Zone to use for this host group.
/// Only single zone is supported. The zone can be assigned only during
/// creation. If not provided, the group supports all zones in the
/// region. If provided, enforces each host in the group to be in the
/// same zone.</param>
public DedicatedHostGroupUpdate(int platformFaultDomainCount, IDictionary<string, string> tags = default(IDictionary<string, string>), IList<SubResourceReadOnly> hosts = default(IList<SubResourceReadOnly>), DedicatedHostGroupInstanceView instanceView = default(DedicatedHostGroupInstanceView), bool? supportAutomaticPlacement = default(bool?), IList<string> zones = default(IList<string>))
public DedicatedHostGroupUpdate(int platformFaultDomainCount, IDictionary<string, string> tags = default(IDictionary<string, string>), IList<SubResourceReadOnly> hosts = default(IList<SubResourceReadOnly>), DedicatedHostGroupInstanceView instanceView = default(DedicatedHostGroupInstanceView), bool? supportAutomaticPlacement = default(bool?), DedicatedHostGroupPropertiesAdditionalCapabilities additionalCapabilities = default(DedicatedHostGroupPropertiesAdditionalCapabilities), IList<string> zones = default(IList<string>))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need customization

/// <param name="zones">Availability Zone to use for this host group.
/// Only single zone is supported. The zone can be assigned only during
/// creation. If not provided, the group supports all zones in the
/// region. If provided, enforces each host in the group to be in the
/// same zone.</param>
public DedicatedHostGroup(string location, int platformFaultDomainCount, string id = default(string), string name = default(string), string type = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), IList<SubResourceReadOnly> hosts = default(IList<SubResourceReadOnly>), DedicatedHostGroupInstanceView instanceView = default(DedicatedHostGroupInstanceView), bool? supportAutomaticPlacement = default(bool?), IList<string> zones = default(IList<string>))
public DedicatedHostGroup(string location, int platformFaultDomainCount, string id = default(string), string name = default(string), string type = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), IList<SubResourceReadOnly> hosts = default(IList<SubResourceReadOnly>), DedicatedHostGroupInstanceView instanceView = default(DedicatedHostGroupInstanceView), bool? supportAutomaticPlacement = default(bool?), DedicatedHostGroupPropertiesAdditionalCapabilities additionalCapabilities = default(DedicatedHostGroupPropertiesAdditionalCapabilities), IList<string> zones = default(IList<string>))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need customization

@grizzlytheodore
Copy link
Member

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Azure Azure deleted a comment from azure-pipelines bot Apr 16, 2022
@Azure Azure deleted a comment from azure-pipelines bot Apr 16, 2022
@grizzlytheodore grizzlytheodore merged commit 661f8cc into Azure:feature/cplat-2022-03-01 Apr 18, 2022
grizzlytheodore added a commit that referenced this pull request May 10, 2022
…rty in Dedicated Hosts for API version 2022-03-01 Compute #27949 (#27984)

* generated

* updated code

Co-authored-by: Theodore Chang <thchan@microsoft.com>
Yao725 pushed a commit that referenced this pull request May 13, 2022
* generated from new folder

* fix updateed object

* updated recordings for 2022-03-01

* new recordings

* last recordings and test fixes

* fix dedicated host test

* add ;

* mitigate failing test

* fix last test recording

* Generated SDK modules and recorded tests for UltraSSDCapability property in Dedicated Hosts for API version 2022-03-01 Compute #27949 (#27984)

* generated

* updated code

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* update with latest swagger form

* dedicatedHost customization

* small ssdk change 1.1 (#28006)

* [RestorePoints] InstanceView Fix SDK changes (#28188)

* sdk changes for instanview fix 1.1

* added record tests 2.1

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* SDK changes for Vmss Flex deleteOption (#27923)

* delete option vmss flex

* record test

* newline

* regenerated sdk

Co-authored-by: Kimberly Yip Chang <kiyipcha@microsoft.com>

* Updated tests for changes in PR Azure/azure-rest-api-specs#18609 (#28063)

* Generated SDK

* added tests, playback recordings for VM and VMSS application profile

(cherry picked from commit c08e89b426bb6dd41b9a37ecb3d42ad172509f89)

* Fixed and re-recoded galley application and gallery application version tests

* Added changes that were created by SDK generation for dedicated HostGroup, but unrelated to my Swagger changes

* added changes to SdkInfo_ComputeManagementClient.cs and compute_resource-management.txt file that were created by SDK generation.

* Undid changes to eng/mgmt/mgmtmetadata/compute_resource-manager.txt

* Undid changes to sdk\compute\Microsoft.Azure.Management.Compute\src\Generated\SdkInfo_ComputeManagementClient.cs

* Re-created the SDK withhout changes to gallery.json and undid changes to test.

* Added test recordings for VM and VMSS application profile.

* remove changes from tests that were not re-recorded

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* generated from new folder

* fix updateed object

* updated recordings for 2022-03-01

* new recordings

* last recordings and test fixes

* fix dedicated host test

* add ;

* mitigate failing test

* fix last test recording

* Generated SDK modules and recorded tests for UltraSSDCapability property in Dedicated Hosts for API version 2022-03-01 Compute #27949 (#27984)

* generated

* updated code

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* update with latest swagger form

* dedicatedHost customization

* small ssdk change 1.1 (#28006)

* [RestorePoints] InstanceView Fix SDK changes (#28188)

* sdk changes for instanview fix 1.1

* added record tests 2.1

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* SDK changes for Vmss Flex deleteOption (#27923)

* delete option vmss flex

* record test

* newline

* regenerated sdk

Co-authored-by: Kimberly Yip Chang <kiyipcha@microsoft.com>

* Updated tests for changes in PR Azure/azure-rest-api-specs#18609 (#28063)

* Generated SDK

* added tests, playback recordings for VM and VMSS application profile

(cherry picked from commit c08e89b426bb6dd41b9a37ecb3d42ad172509f89)

* Fixed and re-recoded galley application and gallery application version tests

* Added changes that were created by SDK generation for dedicated HostGroup, but unrelated to my Swagger changes

* added changes to SdkInfo_ComputeManagementClient.cs and compute_resource-management.txt file that were created by SDK generation.

* Undid changes to eng/mgmt/mgmtmetadata/compute_resource-manager.txt

* Undid changes to sdk\compute\Microsoft.Azure.Management.Compute\src\Generated\SdkInfo_ComputeManagementClient.cs

* Re-created the SDK withhout changes to gallery.json and undid changes to test.

* Added test recordings for VM and VMSS application profile.

* remove changes from tests that were not re-recorded

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* without preview release

* Delete VMApplicationProfile_Tests.json

* Delete TestVMScaleSetApplicationProfile.json

* fix VMTestBase for DH

* resolve tests

* update version name

* Sanitize SAS and key

* Update Microsoft.Azure.Management.Compute.csproj

Co-authored-by: hari-bodicherla <43284966+hari-bodicherla@users.noreply.github.com>
Co-authored-by: prchin <101265062+prchin@users.noreply.github.com>
Co-authored-by: Kimberly Yip Chang <kimberlyyipc@gmail.com>
Co-authored-by: Kimberly Yip Chang <kiyipcha@microsoft.com>
Co-authored-by: Bhaskar Brahma <bhbrahma@microsoft.com>
paterasMSFT pushed a commit that referenced this pull request Jun 15, 2022
* generated from new folder

* fix updateed object

* updated recordings for 2022-03-01

* new recordings

* last recordings and test fixes

* fix dedicated host test

* add ;

* mitigate failing test

* fix last test recording

* Generated SDK modules and recorded tests for UltraSSDCapability property in Dedicated Hosts for API version 2022-03-01 Compute #27949 (#27984)

* generated

* updated code

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* update with latest swagger form

* dedicatedHost customization

* small ssdk change 1.1 (#28006)

* [RestorePoints] InstanceView Fix SDK changes (#28188)

* sdk changes for instanview fix 1.1

* added record tests 2.1

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* SDK changes for Vmss Flex deleteOption (#27923)

* delete option vmss flex

* record test

* newline

* regenerated sdk

Co-authored-by: Kimberly Yip Chang <kiyipcha@microsoft.com>

* Updated tests for changes in PR Azure/azure-rest-api-specs#18609 (#28063)

* Generated SDK

* added tests, playback recordings for VM and VMSS application profile

(cherry picked from commit c08e89b426bb6dd41b9a37ecb3d42ad172509f89)

* Fixed and re-recoded galley application and gallery application version tests

* Added changes that were created by SDK generation for dedicated HostGroup, but unrelated to my Swagger changes

* added changes to SdkInfo_ComputeManagementClient.cs and compute_resource-management.txt file that were created by SDK generation.

* Undid changes to eng/mgmt/mgmtmetadata/compute_resource-manager.txt

* Undid changes to sdk\compute\Microsoft.Azure.Management.Compute\src\Generated\SdkInfo_ComputeManagementClient.cs

* Re-created the SDK withhout changes to gallery.json and undid changes to test.

* Added test recordings for VM and VMSS application profile.

* remove changes from tests that were not re-recorded

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* generated from new folder

* fix updateed object

* updated recordings for 2022-03-01

* new recordings

* last recordings and test fixes

* fix dedicated host test

* add ;

* mitigate failing test

* fix last test recording

* Generated SDK modules and recorded tests for UltraSSDCapability property in Dedicated Hosts for API version 2022-03-01 Compute #27949 (#27984)

* generated

* updated code

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* update with latest swagger form

* dedicatedHost customization

* small ssdk change 1.1 (#28006)

* [RestorePoints] InstanceView Fix SDK changes (#28188)

* sdk changes for instanview fix 1.1

* added record tests 2.1

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* SDK changes for Vmss Flex deleteOption (#27923)

* delete option vmss flex

* record test

* newline

* regenerated sdk

Co-authored-by: Kimberly Yip Chang <kiyipcha@microsoft.com>

* Updated tests for changes in PR Azure/azure-rest-api-specs#18609 (#28063)

* Generated SDK

* added tests, playback recordings for VM and VMSS application profile

(cherry picked from commit c08e89b426bb6dd41b9a37ecb3d42ad172509f89)

* Fixed and re-recoded galley application and gallery application version tests

* Added changes that were created by SDK generation for dedicated HostGroup, but unrelated to my Swagger changes

* added changes to SdkInfo_ComputeManagementClient.cs and compute_resource-management.txt file that were created by SDK generation.

* Undid changes to eng/mgmt/mgmtmetadata/compute_resource-manager.txt

* Undid changes to sdk\compute\Microsoft.Azure.Management.Compute\src\Generated\SdkInfo_ComputeManagementClient.cs

* Re-created the SDK withhout changes to gallery.json and undid changes to test.

* Added test recordings for VM and VMSS application profile.

* remove changes from tests that were not re-recorded

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* without preview release

* Delete VMApplicationProfile_Tests.json

* Delete TestVMScaleSetApplicationProfile.json

* fix VMTestBase for DH

* resolve tests

* update version name

* Sanitize SAS and key

* Update Microsoft.Azure.Management.Compute.csproj

Co-authored-by: hari-bodicherla <43284966+hari-bodicherla@users.noreply.github.com>
Co-authored-by: prchin <101265062+prchin@users.noreply.github.com>
Co-authored-by: Kimberly Yip Chang <kimberlyyipc@gmail.com>
Co-authored-by: Kimberly Yip Chang <kiyipcha@microsoft.com>
Co-authored-by: Bhaskar Brahma <bhbrahma@microsoft.com>
zhihaoxue pushed a commit to zhihaoxue/azure-sdk-for-net that referenced this pull request Jul 27, 2022
* generated from new folder

* fix updateed object

* updated recordings for 2022-03-01

* new recordings

* last recordings and test fixes

* fix dedicated host test

* add ;

* mitigate failing test

* fix last test recording

* Generated SDK modules and recorded tests for UltraSSDCapability property in Dedicated Hosts for API version 2022-03-01 Compute Azure#27949 (Azure#27984)

* generated

* updated code

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* update with latest swagger form

* dedicatedHost customization

* small ssdk change 1.1 (Azure#28006)

* [RestorePoints] InstanceView Fix SDK changes (Azure#28188)

* sdk changes for instanview fix 1.1

* added record tests 2.1

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* SDK changes for Vmss Flex deleteOption (Azure#27923)

* delete option vmss flex

* record test

* newline

* regenerated sdk

Co-authored-by: Kimberly Yip Chang <kiyipcha@microsoft.com>

* Updated tests for changes in PR Azure/azure-rest-api-specs#18609 (Azure#28063)

* Generated SDK

* added tests, playback recordings for VM and VMSS application profile

(cherry picked from commit c08e89b426bb6dd41b9a37ecb3d42ad172509f89)

* Fixed and re-recoded galley application and gallery application version tests

* Added changes that were created by SDK generation for dedicated HostGroup, but unrelated to my Swagger changes

* added changes to SdkInfo_ComputeManagementClient.cs and compute_resource-management.txt file that were created by SDK generation.

* Undid changes to eng/mgmt/mgmtmetadata/compute_resource-manager.txt

* Undid changes to sdk\compute\Microsoft.Azure.Management.Compute\src\Generated\SdkInfo_ComputeManagementClient.cs

* Re-created the SDK withhout changes to gallery.json and undid changes to test.

* Added test recordings for VM and VMSS application profile.

* remove changes from tests that were not re-recorded

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* generated from new folder

* fix updateed object

* updated recordings for 2022-03-01

* new recordings

* last recordings and test fixes

* fix dedicated host test

* add ;

* mitigate failing test

* fix last test recording

* Generated SDK modules and recorded tests for UltraSSDCapability property in Dedicated Hosts for API version 2022-03-01 Compute Azure#27949 (Azure#27984)

* generated

* updated code

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* update with latest swagger form

* dedicatedHost customization

* small ssdk change 1.1 (Azure#28006)

* [RestorePoints] InstanceView Fix SDK changes (Azure#28188)

* sdk changes for instanview fix 1.1

* added record tests 2.1

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* SDK changes for Vmss Flex deleteOption (Azure#27923)

* delete option vmss flex

* record test

* newline

* regenerated sdk

Co-authored-by: Kimberly Yip Chang <kiyipcha@microsoft.com>

* Updated tests for changes in PR Azure/azure-rest-api-specs#18609 (Azure#28063)

* Generated SDK

* added tests, playback recordings for VM and VMSS application profile

(cherry picked from commit c08e89b426bb6dd41b9a37ecb3d42ad172509f89)

* Fixed and re-recoded galley application and gallery application version tests

* Added changes that were created by SDK generation for dedicated HostGroup, but unrelated to my Swagger changes

* added changes to SdkInfo_ComputeManagementClient.cs and compute_resource-management.txt file that were created by SDK generation.

* Undid changes to eng/mgmt/mgmtmetadata/compute_resource-manager.txt

* Undid changes to sdk\compute\Microsoft.Azure.Management.Compute\src\Generated\SdkInfo_ComputeManagementClient.cs

* Re-created the SDK withhout changes to gallery.json and undid changes to test.

* Added test recordings for VM and VMSS application profile.

* remove changes from tests that were not re-recorded

Co-authored-by: Theodore Chang <thchan@microsoft.com>

* without preview release

* Delete VMApplicationProfile_Tests.json

* Delete TestVMScaleSetApplicationProfile.json

* fix VMTestBase for DH

* resolve tests

* update version name

* Sanitize SAS and key

* Update Microsoft.Azure.Management.Compute.csproj

Co-authored-by: hari-bodicherla <43284966+hari-bodicherla@users.noreply.github.com>
Co-authored-by: prchin <101265062+prchin@users.noreply.github.com>
Co-authored-by: Kimberly Yip Chang <kimberlyyipc@gmail.com>
Co-authored-by: Kimberly Yip Chang <kiyipcha@microsoft.com>
Co-authored-by: Bhaskar Brahma <bhbrahma@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants