Add reflection-based Search index definition #2536
Conversation
|
Can one of the admins verify this patch? |
|
Hi @idg10, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
|
@idg10, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
| } | ||
| else if ((indexAnalyzerAttribute = attribute as IndexAnalyzerAttribute) != null) | ||
| { | ||
| field.IndexAnalyzer = AnalyzerName.Create(((IndexAnalyzerAttribute) attribute).Name); |
There was a problem hiding this comment.
I missed this earlier. It looks like the cast to IndexAnalyzerAttribute is unnecessary if you use the indexAnalyzerAttribute variable instead.
There was a problem hiding this comment.
Fixed in f46c44c (resquashed)
| /// Standard ASCII Folding Lucene analyzer. | ||
| /// <see href="https://msdn.microsoft.com/library/azure/mt605304.aspx#Analyzers" /> | ||
| /// </summary> | ||
| public static readonly AnalyzerName StandardAsciiFoldingLucene = |
There was a problem hiding this comment.
Fixed in f46c44c (resquashed)
2d7637e to
f46c44c
Compare
|
I've fixed both of the problems you found (the unnecessary repeated cast, and my bizarre error in |
|
@azuresdkci add to whitelist |
|
LGTM once the build passes |
|
@markcowl The build passed; Please merge |
This implements #2427
For the unsquashed history see https://github.com/idg10/azure-sdk-for-net/tree/reflection-schema which includes discussion with @brjohnstmsft as he reviewed my work on this feature.