Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TA] Enable multiversion #21353

Merged
merged 4 commits into from
May 28, 2021
Merged

[TA] Enable multiversion #21353

merged 4 commits into from
May 28, 2021

Conversation

maririos
Copy link
Member

Enable multi-version support.

  • Adds a transform to swagger (service is adding this to swagger, so when it is merged I will delete the transform)
  • Adds tests fixture so we can test v3.0 and v3.1-preview5 with the current SDK version
  • Add information about different versions in Readme
  • Methods and properties affected by version have docs updated

Fixes: #20858

@maririos maririos requested a review from annelo-msft as a code owner May 25, 2021 23:01
@maririos
Copy link
Member Author

/azp run net - textanalytics - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maririos
Copy link
Member Author

/azp run net - textanalytics - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

kristapratico
kristapratico approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maririos maririos requested a review from mshaban-msft May 27, 2021 15:46
kinelski
kinelski approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@kinelski kinelski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the table comment, LGTM!

@maririos maririos merged commit 476e7e8 into Azure:master May 28, 2021
deyaaeldeen
deyaaeldeen reviewed Jun 7, 2021
View reviewed changes
sdk/textanalytics/Azure.AI.TextAnalytics/src/autorest.md
@@ -21,6 +21,29 @@ directive:
$["x-accessibility"] = "internal"
```

### Make the API version parameterized so we generate a multi-versioned API

This should be fixed in the swagger, but we're working around it locally for now.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding an API version as a parameter to the endpoint instead of having it fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deyaaeldeen deyaaeldeen deyaaeldeen left review comments

@kinelski kinelski kinelski approved these changes

@kristapratico kristapratico kristapratico approved these changes

@iscai-msft iscai-msft Awaiting requested review from iscai-msft

@mssfang mssfang Awaiting requested review from mssfang

@annelo-msft annelo-msft Awaiting requested review from annelo-msft

@mshaban-msft mshaban-msft Awaiting requested review from mshaban-msft

Assignees
No one assigned
Labels
Cognitive - Text Analytics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allor multi-version support
4 participants
@maririos @deyaaeldeen @kinelski @kristapratico