[Identity] Exclude SharedTokenCacheCredential from DefaultAzureCredential by default #16615
Conversation
|
Converted this to a Draft PR as it should not be merged until after the GA of Azure.Identity 1.3.0, and once the feature/identity/140 branch has been merged back to master. |
|
Hi @schaabs. There hasn't been recent engagement on this PR and it looks like v1.3.0 has been released to GA as the comment mentioned. Would you please be so kind as to let us know if this is still an active work stream or if the PR should be closed out? |
…nto identity-dacremstcc
|
@jsquire, This does still need to be merged in ahead of our next beta release. I've updated it and marked it ready for review. |
|
related to #16306 |
| ### Breaking Changes | ||
| - Update the default value of `ExcludeSharedTokenCacheCredential` on `DefaultAzureCredentialsOptions` to true, to exclude the `SharedTokenCacheCredential` from the `DefaultAzureCredential` by default. | ||
|
|
There was a problem hiding this comment.
This needs to move up to the latest release.
…nto identity-dacremstcc
|
|
||
| ## 1.4.0 | ||
|
|
||
| ### Changed `ExcludeSharedTokenCacheCredential` default value on `DefaultAzureCredentialsOptions` |
There was a problem hiding this comment.
| ### Changed `ExcludeSharedTokenCacheCredential` default value on `DefaultAzureCredentialsOptions` | |
| ### Changed `ExcludeSharedTokenCacheCredential` default value from `false` to `true` on `DefaultAzureCredentialsOptions` |
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| ## 1.4.0-beta.4 (Unreleased) | |||
|
|
|||
| ### Breaking Changes | |||
| - Update the default value of `ExcludeSharedTokenCacheCredential` on `DefaultAzureCredentialsOptions` to true, to exclude the `SharedTokenCacheCredential` from the `DefaultAzureCredential` by default. | |||
There was a problem hiding this comment.
Did you intend to reference the BREAKING_CHANGES.md here?
There was a problem hiding this comment.
I do want to reference it but I believe it should be an absolute link since this the changelog gets put into the nupkg. I was planning on doing this as a separate change unless you have a better way to accomplish this.
There was a problem hiding this comment.
I think the link checker does the right thing with the absolute links. It may just work.
#13228
fixes #17052