Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event Hubs] Canary support for live tests #15265

Merged
merged 4 commits into from
Sep 29, 2020

Conversation

HarshaNalluru
Copy link
Member

@HarshaNalluru HarshaNalluru commented Sep 18, 2020

@ghost ghost added the Event Hubs label Sep 18, 2020
@HarshaNalluru HarshaNalluru marked this pull request as ready for review September 25, 2020 21:13
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about switching to .NET Core but otherwise looks reasonable.

@weshaggard
Copy link
Member

@damirault please keep this change in mind while working on @danieljurek other PR. We should see how these two should be combined.

@damirault
Copy link
Contributor

#15285 is the other PR @weshaggard is referencing.

@HarshaNalluru
Copy link
Member Author

@HarshaNalluru HarshaNalluru merged commit c49fc87 into Azure:master Sep 29, 2020
Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've seen a few runs manually triggered in the past week and they seem to be coming back clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants