-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Event Hubs] Canary support for live tests #15265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about switching to .NET Core but otherwise looks reasonable.
@damirault please keep this change in mind while working on @danieljurek other PR. We should see how these two should be combined. |
#15285 is the other PR @weshaggard is referencing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've seen a few runs manually triggered in the past week and they seem to be coming back clean.
Last triggered pipeline - https://dev.azure.com/azure-sdk/internal/_build/results?buildId=553341&view=results
More relevant info - Azure/azure-sdk-for-js#11318