Identity fix regression in InteractiveBrowserCredential from invalid redirectUrl #14393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
approved these changes
Aug 20, 2020
g2vinay
approved these changes
Aug 20, 2020
|
/azp run net - identity - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AlexanderSher
approved these changes
Aug 20, 2020
schaabs
added a commit
to schaabs/azure-sdk-for-net
that referenced
this pull request
Aug 20, 2020
schaabs
added a commit
that referenced
this pull request
Aug 21, 2020
* Patch TaskExtensions bug in Azure.Identity 1.2.0 (#14309) * Identity cherry-pick InteractiveBrowserCredential fix for 1.2.2 hotfix (#14412) * Identity fix regression in InteractiveBrowserCredential from invalid redirectUrl (#14393) * Azure.Identity update CHANGELOG.md for 1.2.2 release * updating version Co-authored-by: Pavel Krymets <pavel@krymets.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression was introduced in the
InteractiveBrowserCredentialwhen refactoring MSAL client usage in this commit. Previously theInteractiveBrowserCredentialwas using the hard-coded redirectUrl "http://localhost/". This was erroneously updated tonullin the aforementioned change.Fixes: #13940