-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Backup Health #12543
Azure Backup Health #12543
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swagger PR : Azure/azure-rest-api-specs#9711 |
<PackageReleaseNotes> | ||
<![CDATA[ | ||
New features: | ||
- Added changes for Azure Backup Health. | ||
]]> | ||
<![CDATA[ | ||
New features: | ||
- Added 4 new rest api related to private endpoint connection work (JEDI). | ||
]]> | ||
</PackageReleaseNotes> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lapradh this looks like a bad merge. There should be only one <![CDATA[
]]>
block within <PackageReleaseNotes>
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls review now
And please also resolve the conflicts, as another PR of recovery service backup is merged #12650 |
/check-enforcer reset |
/check-enforcer evaluate |
/azp run net - mgmt - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Azure BAckup Health * added metadata and release notes * Revert "added metadata and release notes" This reverts commit 4e3038b. * Revert "Azure BAckup Health" This reverts commit 3caab3e. * heath kpi changes * merge * Update Microsoft.Azure.Management.RecoveryServices.Backup.csproj updated version to match latest * Update AzureVmWorkloadSQLDatabaseProtectedItem.cs added health details * Update Microsoft.Azure.Management.RecoveryServices.Backup.csproj dummy check in * Update Microsoft.Azure.Management.RecoveryServices.Backup.csproj dummy checkin
Updated health details
openapi spec review PR : Azure/azure-rest-api-specs#9711
Check in the metadata TXT file generated when you run generate.ps1(details) : Done
Update api tag in AzSdk.RP.props, release notes in csproj : updated release notes.
Update versions in csproj and assemblyinfo.cs if you are going to release : no new version. so not required.