[Event Hubs Client] Event Source and README Updates #12214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshLove-msft
approved these changes
May 20, 2020
conniey
approved these changes
May 21, 2020
ShivangiReja
approved these changes
May 21, 2020
4932c50 to
829d09e
Compare
The focus of these changes is to provide a cleaner surface for mocking diagnostic event sources, preventing the default constructor from running and ensuring the mock does not emit messages to the named event source nor apply the standard traits hooked by the Azure listeners. Language requirement blurbs in the README files for Event Hubs and Service Bus have been updated to remove confusing wording and provide better guidance on the use of C# 8 in the libraries.
829d09e to
19b588c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to provide a cleaner surface for mocking diagnostic event sources, preventing the default constructor from running and
ensuring the mock does not emit messages to the named event source nor apply the standard traits hooked by the Azure listeners.
Language requirement blurbs in the README files for Event Hubs and Service Bus have been updated to remove confusing wording and provide better guidance on the use of C# 8 in the libraries.
Last Upstream Rebase
Wednesday, May 20, 4:54pm (EDT)