Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docs.MS Release Steps #12091

Merged
merged 17 commits into from
May 20, 2020
Merged

Add Docs.MS Release Steps #12091

merged 17 commits into from
May 20, 2020

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented May 15, 2020

And refactor the artifact staging a bit.

@Azure/azure-sdk-eng

@weshaggard I've removed a bunch of New-Item invocations in favor of a Copy-Item with -Force parameter. If we know we're copying into a clean directory, do you see any downsides to this approach?

Example Successful Release

@weshaggard
Copy link
Member

@weshaggard I've removed a bunch of New-Item invocations in favor of a Copy-Item with -Force parameter. If we know we're copying into a clean directory, do you see any downsides to this approach?

Does copy-item -force also create directories?

@weshaggard
Copy link
Member

Does copy-item -force also create directories?

Based on a quick test it doesn't appear to so you still need to new-items to create the directories.

@scbedd scbedd requested a review from AlexGhiondea as a code owner May 18, 2020 22:07
@scbedd
Copy link
Member Author

scbedd commented May 18, 2020

@weshaggard I completed some local testing. I'm fairly confident that my approach for New-Item will be safe. I've got everything the way I want it except for the publish to nuget (which got commented). I'll uncomment, squash, and checkin when I have the successful release.

@scbedd scbedd merged commit 78e8bca into master May 20, 2020
@scbedd scbedd deleted the feature/enable-docsms-release branch May 20, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants