Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain mgmt project list #11613

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Maintain mgmt project list #11613

merged 1 commit into from
Apr 28, 2020

Conversation

isra-fel
Copy link
Member

Description

Add new service: synapse
Rename: cosmos-db -> cosmosdb

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@isra-fel isra-fel added Mgmt-EngSys Engineering System (Management Plane Specific) needs-review labels Apr 27, 2020
@isra-fel
Copy link
Member Author

/check-enforcer reset

@isra-fel
Copy link
Member Author

/check-enforcer evaluate

@mitchdenny
Copy link
Contributor

/check-enforcer success

1 similar comment
@mitchdenny
Copy link
Contributor

/check-enforcer success

@mitchdenny
Copy link
Contributor

@isra-fel I'm not sure why this PR is stuck on Check Enforcer. Pushing another commit will likely clear it up. Will need to do some investigation on this PR as to why it is messed up.

@mitchdenny
Copy link
Contributor

/check-enforcer evaluate

@mitchdenny
Copy link
Contributor

/check-enforcer success

@mitchdenny
Copy link
Contributor

Found the bug ... once this PR is approved I can do an override to merge this one for you. Hopefully the bug in Check Enforcer will be fixed soon.

@mitchdenny
Copy link
Contributor

... a new commit will fix it though.

@isra-fel
Copy link
Member Author

Thanks Mitch. I force pushed again.

@isra-fel isra-fel merged commit 8c4c2a3 into Azure:master Apr 28, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this pull request Nov 18, 2020
CodeGen from PR 11613 in Azure/azure-rest-api-specs
a57c347 
Change PartitionOption to object to allow expression (Azure#11613)

* add httpRequestTimeout to odata based connector activities

* add httpRequestTimeout to odata based connector activities

* add sql parallel read properties

* change partitionOption to object

* change ParallelOption to object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chidozieononiwu chidozieononiwu chidozieononiwu approved these changes

@danieljurek danieljurek Awaiting requested review from danieljurek

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@weshaggard weshaggard Awaiting requested review from weshaggard

Assignees

@isra-fel isra-fel

@erich-wang erich-wang

Labels
Mgmt-EngSys Engineering System (Management Plane Specific)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isra-fel @mitchdenny @chidozieononiwu @erich-wang