Create initial test-resources.json for tables #11538
Conversation
|
This looks good but I would merge it along with at least one test that uses it. Do you have live pipeline setup? |
I only have the auto generated ones for CI etc. I was planning to work on setting up the pipeline next. |
| { | ||
| request.Headers.Add("x-ms-client-request-id", requestId); | ||
| } | ||
| // Delete requests fail without this header. |
There was a problem hiding this comment.
Should we add it to swagger?
There was a problem hiding this comment.
It's debatable. I think the answer is yes.
Comparing notes with what happens in python, this header appears to not be required, although is harmless if added. In addition, I was able to run fiddler against Azure Storage Explorer in the portal, and it sends this header. The documentation doesn't mention it.
There was a problem hiding this comment.
Let's comment on the swagger PR at least and see how that goes.
No description provided.