Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Attestation Readme issues #20745

Closed
Tianyun-G opened this issue Apr 29, 2021 · 1 comment · Fixed by #20558
Closed

Azure Attestation Readme issues #20745

Tianyun-G opened this issue Apr 29, 2021 · 1 comment · Fixed by #20558
Assignees
Labels
Attestation Client This issue points to a problem in the data-plane of the library. Docs test-manual-pass

Comments

@Tianyun-G
Copy link
Contributor

Section link:
image
Reason: This link is wrong.
Suggestion:
Update the link to: https://github.com/Azure/azure-sdk-for-net/tree/master/sdk/attestation/Azure.Security.Attestation/src

Section link:
image

Suggestion:
1.Update [Microsoft Open Source Code of Conduct][microsoft_code_of_conduct] to 'Microsoft Open Source Code of Conduct'

2.Add hyperlink for Code of Conduct FAQ https://opensource.microsoft.com/codeofconduct/faq/

Section link:
image
Suggestion: Remove a management

@jongio for notification.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 29, 2021
@v-xuto v-xuto added Attestation Client This issue points to a problem in the data-plane of the library. Docs needs-team-triage Workflow: This issue needs the team to triage. test-manual-pass labels Apr 29, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 29, 2021
@jsquire jsquire removed the needs-team-triage Workflow: This issue needs the team to triage. label Apr 29, 2021
@LarryOsterman
Copy link
Member

Thank you very much. I'll address all of them except the last - it is not a typo, these are apis for managing the policy management apis, thus policy management management. The text here is intended to be a humorous element. I could change it to "yes, there are APIs for managing policy management", but that loses the punch somewhat.

LarryOsterman added a commit to LarryOsterman/azure-sdk-for-net that referenced this issue Apr 29, 2021
@LarryOsterman LarryOsterman linked a pull request Apr 29, 2021 that will close this issue
11 tasks
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this issue Nov 3, 2022
Azure Relay - added missing publicNetworkAccess at NetwrokRuleSet level (Azure#20745)

* Update NetworkRuleSets.json Revised

Customer wanted to disable publicNetworkAccess via ARM template. Doc is not updated. I have tested it locally and found that publicNetworkAccess property should be part of NetworkRuleSet
{

      "type": "Microsoft.Relay/namespaces/networkRuleSets",

      "apiVersion": "2021-11-01",

      "name": "samplehyb1232434/default",

      "location": "East US",

      "dependsOn": [

        "[resourceId('Microsoft.Relay/namespaces', 'samplehyb1232434')]"

      ],

      "properties": {

        "defaultAction": "Allow",

        "ipRules": [

          {}

        ],

       "publicNetworkAccess": "Disabled"

      }

    }

* fixed lint and prettier

* updated readme for typescript

* updated description

Co-authored-by: Ajit Maruti Navasare (MINDTREE LIMITED) <v-ajnav@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Attestation Client This issue points to a problem in the data-plane of the library. Docs test-manual-pass
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants