Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ClientRequestId from SearchClientOptions #12109

Closed
heaths opened this issue May 15, 2020 · 0 comments · Fixed by #12224
Closed

Remove ClientRequestId from SearchClientOptions #12109

heaths opened this issue May 15, 2020 · 0 comments · Fixed by #12224
Assignees
@tg-msft @heaths
Labels
Client This issue points to a problem in the data-plane of the library. Search
Milestone
[2020] June

Comments

@heaths
Copy link
Member

heaths commented May 15, 2020

Based on team discussion, remove SearchClientOptions.ClientRequestId.
@heaths heaths added KeyVault Client This issue points to a problem in the data-plane of the library. labels May 15, 2020
@heaths heaths added this to the [2020] June milestone May 15, 2020
@heaths heaths modified the milestones: [2020] June, [2020] July May 20, 2020
@heaths heaths added Search and removed KeyVault labels May 20, 2020
@heaths heaths mentioned this issue May 21, 2020
Merged
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue May 21, 2020
@heaths
Remove ClientRequestId property from requests
194c02d 
Fixes Azure#12109
heaths added a commit that referenced this issue May 21, 2020
@heaths
Remove ClientRequestId property from requests (#12224)
f8ad540 
* Remove ClientRequestId property from requests

Fixes #12109

* Update public APIs

* Remove SearchRequestOptoins class entirely

* Resolve PR feedback

Some parameters to callees were indented oddly.
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tg-msft tg-msft

@heaths heaths

Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Milestone
[2020] June
Development

Successfully merging a pull request may close this issue.

Remove ClientRequestId property from requests heaths/azure-sdk-for-net
2 participants
@tg-msft @heaths